Add missing up-to-date configuration #35255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source properties file and the dynamic elasticsearch version (set based on properties ) were missing from task outputs leading to the task being incorrectly considered up to date. Closes elastic#35204
alpar-t
added
>non-issue
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra |
nik9000
reviewed
Nov 5, 2018
| version = props.getProperty("elasticsearch") | ||
| processResources { | ||
| inputs.file(project.file('version.properties')) | ||
| inputs.property("dynamic_elasticsearch_version", props.getProperty("elasticsearch")) |
Member
There was a problem hiding this comment.
Do we need this one? The ES version already comes from the file, right?
Contributor
Author
There was a problem hiding this comment.
Yes, we add snapshot and qualifier from parameters to it.
buildSrc/build.gradle
Outdated
| // we update the version property to reflect if we are building a snapshot or a release build | ||
| // we write this back out below to load it in the Build.java which will be shown in rest main action | ||
| // to indicate this being a snapshot build or a release build. | ||
| Properties props = VersionPropertiesLoader.loadBuildSrcVersion(project.file('version.properties')) |
Member
There was a problem hiding this comment.
Maybe make a File versionProperties = project.file('version.properties') variable so it is obvious we reference it twice.
Contributor
Author
|
@nik9000 thanks for reviewing. I implemented your suggestions and am going to merge because it's causing failures for people locally as the Lucene snapshot was updated. |
alpar-t
added a commit
that referenced
this pull request
Nov 6, 2018
* Add missing up-to-date configuration The source properties file and the dynamic elasticsearch version (set based on properties ) were missing from task outputs leading to the task being incorrectly considered up to date. Closes #35204
matarrese
added a commit
to matarrese/elasticsearch
that referenced
this pull request
Nov 6, 2018
…-agg * master: (528 commits) Register Azure max_retries setting (elastic#35286) add version 6.4.4 [Docs] Add painless context details for bucket_script (elastic#35142) Upgrade jline to 3.8.2 (elastic#35288) SQL: new SQL CLI logo (elastic#35261) Logger: Merge ESLoggerFactory into Loggers (elastic#35146) Docs: Add section about range query for range type (elastic#35222) [ILM] change remove-policy-from-index http method from DELETE to POST (elastic#35268) [CCR] Forgot missing return statement, SQL: Fix null handling for AND and OR in SELECT (elastic#35277) [TEST] Mute ChangePolicyForIndexIT#testChangePolicyForIndex Serialize ignore_throttled also to 6.6 after backport Check for java 11 in buildSrc (elastic#35260) [TEST] increase await timeout in RemoteClusterConnectionTests Add missing up-to-date configuration (elastic#35255) Adapt Lucene BWC version SQL: Introduce Coalesce function (elastic#35253) Upgrade to lucene-8.0.0-snapshot-31d7dfe6b1 (elastic#35224) Fix failing ICU tests (elastic#35207) Prevent throttled indices to be searched through wildcards by default (elastic#34354) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source properties file and the dynamic elasticsearch version
(set based on properties ) were missing from task outputs leading
to the task being incorrectly considered up to date.
Closes #35204