TEST: Create following engines in the main thread #33391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two races in the testUpdateAndReadChangesConcurrently if the following engines are created in the worker threads. We fixed the translog issue in elastic#33352, but still another race with `createStore`. This commit ensures that we create the following engines in the main thread. Relates elastic#33352 Closes elastic#33344
dnhatn
added
>test
Collaborator
|
Pinging @elastic/es-distributed |
dnhatn
changed the title
server/src/test/java/org/elasticsearch/index/engine/LuceneChangesSnapshotTests.java
Show resolved
Hide resolved
Member
Author
|
@original-brownbear thanks for reviewing. |
dnhatn
added a commit
that referenced
this pull request
Sep 6, 2018
There are two races in the testUpdateAndReadChangesConcurrently if the following engines are created in the worker threads. We fixed the translog issue in #33352, but there is still another race with createStore. This commit ensures that we create all engines in the main thread. Relates #33352 Closes #33344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two races in the
testUpdateAndReadChangesConcurrentlyif the following engines are created in the worker threads. We fixed the translog issue in #33352, but there is still another race withcreateStore.This commit ensures that we create all following engines in the main thread.
Relates #33352
Closes #33344