TESTS: Fix Race Condition in Temp Path Creation #33352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Calling `createTempDir` concurrently here in the `Follower`s causes collisions at times which lead to `createEngine` throwing because of unexpected files in the newly created temp dir * Fixed by creating all temp dirs in the main test thread * closes elastic#33344
original-brownbear
added
>test-failure
Collaborator
|
Pinging @elastic/es-distributed |
dnhatn
approved these changes
Sep 3, 2018
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this @original-brownbear.
| public void run() { | ||
| try (Store store = createStore(); | ||
| InternalEngine follower = createEngine(store, createTempDir())) { | ||
| InternalEngine follower = createEngine(store, tempDir)) { |
Member
There was a problem hiding this comment.
nit: we should rename tempDir to translogPath
dnhatn
added
>test
Contributor
Author
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Sep 4, 2018
* TESTS: Fix Race Condition in Temp Path Creation * Calling `createTempDir` concurrently here in the `Follower`s causes collisions at times which lead to `createEngine` throwing because of unexpected files in the newly created temp dir * Fixed by creating all temp dirs in the main test thread * closes elastic#33344
original-brownbear
added a commit
that referenced
this pull request
Sep 4, 2018
* TESTS: Fix Race Condition in Temp Path Creation * Calling `createTempDir` concurrently here in the `Follower`s causes collisions at times which lead to `createEngine` throwing because of unexpected files in the newly created temp dir * Fixed by creating all temp dirs in the main test thread * closes #33344
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 4, 2018
…e-default-distribution * elastic/master: (213 commits) ML: Fix build after HLRC change Fix inner hits retrieval when stored fields are disabled (_none_) (elastic#33018) SQL: Show/desc commands now support table ids (elastic#33363) Mute testValidateFollowingIndexSettings HLRC: Add delete by query API (elastic#32782) [ML] The sort field on get records should default to the record_score (elastic#33358) [ML] Minor improvements to categorization Grok pattern creation (elastic#33353) [DOCS] fix a couple of typos (elastic#33356) Disable assemble task instead of removing it (elastic#33348) Simplify the return type of FieldMapper#parse. (elastic#32654) [ML] Delete forecast API (elastic#31134) (elastic#33218) Introduce private settings (elastic#33327) [Docs] Add search timeout caveats (elastic#33354) TESTS: Fix Race Condition in Temp Path Creation (elastic#33352) Fix from_range in search_after in changes snapshot (elastic#33335) TESTS+DISTR.: Fix testIndexCheckOnStartup Flake (elastic#33349) Null completion field should not throw IAE (elastic#33268) Adds code to help with IndicesRequestCacheIT failures (elastic#33313) Prevent NPE parsing the stop datafeed request. (elastic#33347) HLRC: Add ML get overall buckets API (elastic#33297) ...
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Sep 4, 2018
There are two races in the testUpdateAndReadChangesConcurrently if the following engines are created in the worker threads. We fixed the translog issue in elastic#33352, but still another race with `createStore`. This commit ensures that we create the following engines in the main thread. Relates elastic#33352 Closes elastic#33344
dnhatn
added a commit
that referenced
this pull request
Sep 5, 2018
There are two races in the testUpdateAndReadChangesConcurrently if the following engines are created in the worker threads. We fixed the translog issue in #33352, but there is still another race with createStore. This commit ensures that we create all engines in the main thread. Relates #33352 Closes #33344
dnhatn
added a commit
that referenced
this pull request
Sep 6, 2018
There are two races in the testUpdateAndReadChangesConcurrently if the following engines are created in the worker threads. We fixed the translog issue in #33352, but there is still another race with createStore. This commit ensures that we create all engines in the main thread. Relates #33352 Closes #33344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createTempDirconcurrently here inthe
Followers causes collisions at timeswhich lead to
createEnginethrowing becauseof unexpected files in the newly created temp
dir