HLRestClient: Follow-up for put index template api #30592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses some comments given after the original PR was in. Follow-up elastic#30400
Collaborator
|
Pinging @elastic/es-core-infra |
Member
Author
|
Hey @javanna, this addresses your comments in #30400 (comment) . Can you please have a look? Thank you! |
javanna
approved these changes
May 14, 2018
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
left a tiny comment, LGTM otherwise
| * random instance each time it is called. | ||
| */ | ||
| protected abstract T createTestInstance(); | ||
| protected abstract T createTestInstance() throws IOException; |
Member
There was a problem hiding this comment.
I think I would prefer to catch the exception in createTestInstance instead. We should not need this in most of the cases, and it would be nice to keep this aligned with AbstractWireTestCase#createTestInstance
Member
Author
|
@elasticmachine test this please |
Member
Author
|
Thanks @javanna |
dnhatn
added a commit
that referenced
this pull request
May 15, 2018
This commit addresses some comments given after the original PR was in. Follow-up #30400
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 15, 2018
…ngs-to-true * elastic/master: [DOCS] Restores 7.0.0 release notes and highlights Remove assert statements from field caps documentation. (elastic#30601) Repository GCS plugin new client library (elastic#30168) HLRestClient: Follow-up for put index template api (elastic#30592) Unmute IndexUpgradeIT tests [DOCS] Remove references to changelog and to highlights Side-step pending deletes check (elastic#30571) [DOCS] Remove references to removed changelog Revert "Mute ML upgrade test (elastic#30458)" [ML] Adjust BWC version following backport of elastic#30125 [Docs] Improve section detailing translog usage (elastic#30573) [Tests] Relax allowed delta in extended_stats aggregation (elastic#30569) [ML] Reverse engineer Grok patterns from categorization results (elastic#30125) Update build file due to doc file rename Remove the changelog (elastic#30593) Fix issue with finishing handshake in ssl driver (elastic#30580) Fail if reading from closed KeyStoreWrapper (elastic#30394) Silence IndexUpgradeIT test failures. (elastic#30430)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses some comments given after the original PR was in.
Follow-up #30400 (comment)