Skip to content

Minor language change in the section detailing usage of elasticsearch… #30573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2018
Merged

Minor language change in the section detailing usage of elasticsearch… #30573

merged 1 commit into from
May 15, 2018

Conversation

@srini-raman
Copy link
Contributor

@srini-raman srini-raman commented May 14, 2018

…-translog

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

@cbuescher cbuescher added the >docs General docs changes label May 14, 2018
cbuescher
cbuescher approved these changes May 14, 2018
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srini-raman, I think this makes it clearer. Will run our test suite and merge it in once everything is green.

@cbuescher
Copy link
Member

cbuescher commented May 14, 2018

@elasticmachine test this please

@cbuescher cbuescher merged commit 651acee into elastic:6.2 May 15, 2018
cbuescher pushed a commit that referenced this pull request May 15, 2018
@srini-raman
[Docs] Improve section detailing translog usage (#30573)
14a265c
cbuescher pushed a commit that referenced this pull request May 15, 2018
@srini-raman
[Docs] Improve section detailing translog usage (#30573)
e7b5bd9
cbuescher pushed a commit that referenced this pull request May 15, 2018
@srini-raman
[Docs] Improve section detailing translog usage (#30573)
0592b68
@srini-raman
Copy link
Contributor Author

srini-raman commented May 15, 2018

Thank you, cbuescher, for taking care of this...

dnhatn added a commit that referenced this pull request May 15, 2018
@dnhatn
Merge branch '6.x' into ccr-6.x
981884a 
* 6.x:
  Revert "Silence IndexUpgradeIT test failures. (#30430)"
  [DOCS] Remove references to changelog and to highlights
  Revert "Mute ML upgrade test (#30458)"
  [ML] Fix BWC version for backport of #30125
  [Docs] Improve section detailing translog usage (#30573)
  [Tests] Relax allowed delta in extended_stats aggregation (#30569)
  Fail if reading from closed KeyStoreWrapper (#30394)
  [ML] Reverse engineer Grok patterns from categorization results (#30125)
  Derive max composite buffers from max content len
  Update build file due to doc file rename
  SQL: Extract SQL request and response classes (#30457)
  Remove the changelog (#30593)
  Revert "Add deprecation warning for default shards (#30587)"
  Silence IndexUpgradeIT test failures. (#30430)
  Add deprecation warning for default shards (#30587)
  [DOCS] Adds 6.4.0 release highlight pages
  [DOCS] Adds release highlight pages (#30590)
  Docs: Document how to rebuild analyzers (#30498)
  [DOCS] Fixes title capitalization in security content
  LLRest: Add equals and hashcode tests for Request (#30584)
  [DOCS] Fix realm setting names (#30499)
  [DOCS] Fix path info for various security files (#30502)
  Docs: document precision limitations of geo_bounding_box (#30540)
  Fix non existing javadocs link in RestClientTests
  Auto-expand replicas only after failing nodes (#30553)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 15, 2018
@jasontedor
Merge remote-tracking branch 'elastic/master' into default-copy-setti…
48c4166 
…ngs-to-true

* elastic/master:
  [DOCS] Restores 7.0.0 release notes and highlights
  Remove assert statements from field caps documentation. (elastic#30601)
  Repository GCS plugin new client library (elastic#30168)
  HLRestClient: Follow-up for put index template api (elastic#30592)
  Unmute IndexUpgradeIT tests
  [DOCS] Remove references to changelog and to highlights
  Side-step pending deletes check (elastic#30571)
  [DOCS] Remove references to removed changelog
  Revert "Mute ML upgrade test (elastic#30458)"
  [ML] Adjust BWC version following backport of elastic#30125
  [Docs] Improve section detailing translog usage (elastic#30573)
  [Tests] Relax allowed delta in extended_stats aggregation (elastic#30569)
  [ML] Reverse engineer Grok patterns from categorization results (elastic#30125)
  Update build file due to doc file rename
  Remove the changelog (elastic#30593)
  Fix issue with finishing handshake in ssl driver (elastic#30580)
  Fail if reading from closed KeyStoreWrapper (elastic#30394)
  Silence IndexUpgradeIT test failures. (elastic#30430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbuescher cbuescher cbuescher approved these changes

Assignees

No one assigned

Labels

>docs General docs changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srini-raman @cbuescher