Remove several parse field deprecations in query builders #26711
Conversation
cbuescher
force-pushed
the
remove-QueryBuilder-deprecations
branch
from
bf1d915 to
071a506
Compare
cbuescher
force-pushed
the
remove-QueryBuilder-deprecations
branch
from
071a506 to
9ea87f4
Compare
There was a problem hiding this comment.
This assumes these changes should and can be backported to 6.0.0
There was a problem hiding this comment.
The logic seems wrong. I think it should be before and not onOrAfter ?
Also you should do that in multiple steps to avoid build failures. Start with current version (v7), then backport to v6 and when the build is green you can change the expected version here to be v6. You can add a TODO comment to make sure that reviewers understand the expectations.
There was a problem hiding this comment.
Thanks, of course it should be before, bad copy error on my side. Looking at this, I think I will pull out the MatchQueryBuilder changes to a separate PR since I think it will make backporting easier, the rest of this PR is more straight forward.
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
Thanks for doing this @cbuescher !
I left some comments.
There was a problem hiding this comment.
The logic seems wrong. I think it should be before and not onOrAfter ?
Also you should do that in multiple steps to avoid build failures. Start with current version (v7), then backport to v6 and when the build is green you can change the expected version here to be v6. You can add a TODO comment to make sure that reviewers understand the expectations.
The `fielddata` field and the use of the `_name` field in the short syntax of the range query have been deprecated in 5.0 and can be removed.
All of these have already been deprecated in 5.0 and can thus be removed in 6.0.
cbuescher
force-pushed
the
remove-QueryBuilder-deprecations
branch
from
9ea87f4 to
b9273d8
Compare
|
@jimczi thanks for the review, I pulled out the changes in the MatchQueryBuilder and related test into #26720 to make this PR a little smaller and easier to backport. Is there anything to the remaining part you would like to be changed? I was planning to add the notes to the migration docs only when backporting to the 6.0 branch. |
The `fielddata` field and the use of the `_name` field in the short syntax of the range query have been deprecated in 5.0 and can be removed. The same goes for the deprecated `score_mode` field in HasParentQueryBuilder, the deprecated `like_text`, `ids` and `docs` parameter in the `more_like_this` query, the deprecated query name in the short version of the `regexp` query, and several deprecated alternative field names in other query builders.
The `fielddata` field and the use of the `_name` field in the short syntax of the range query have been deprecated in 5.0 and can be removed. The same goes for the deprecated `score_mode` field in HasParentQueryBuilder, the deprecated `like_text`, `ids` and `docs` parameter in the `more_like_this` query, the deprecated query name in the short version of the `regexp` query, and several deprecated alternative field names in other query builders.
* master: [DOCS] Added index-shared4 and index-shared5.asciidoc BulkProcessor flush runnable preserves the thread context from creation time (elastic#26718) Catch exceptions and inform handler in RemoteClusterConnection#collectNodes (elastic#26725) [Docs] Fix name of character filter in example. (elastic#26724) Remove parse field deprecations in query builders (elastic#26711) elastic#26720: Set the correct bwc version after backport to 6.0 Remove deprecated type and slop field in MatchQueryBuilder (elastic#26720) Refactoring of Gateway*** classes (elastic#26706) Make RestHighLevelClient's Request class public (elastic#26627) Deguice ActionFilter (elastic#26691) aggs: Allow aggregation sorting via nested aggregation. Build: Set bwc builds to always set snapshot (elastic#26704) File Discovery: Remove fallback with zen discovery (elastic#26667)
clintongormley
added
:Search/Search
5 participants
This change removes parse fields that are either completely deprecated since version 5.0 or removes deprecated names.
This PR is opened against master, but should be backported to the 6.x and 6.0 branches with additional notes
to the migration docs in 6.0.