Build: Make bwc builds always use snapshot=false #26704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjernst
added
:Delivery/Build
Member
|
Lgtm
…On Mon, Sep 18, 2017, 11:36 PM Ryan Ernst ***@***.***> wrote:
This commit makes the bwc builds use Exec instead of GradleBuild when
doing a release build. This is only relevant in the case of running
tests with a release build, which is only done by CI, so the sub build
in that case is run with info logging.
closes #26702 <#26702>
------------------------------
You can view, comment on, or merge this pull request online at:
#26704
Commit Summary
- Build: Make bwc builds always use snapshot=false
File Changes
- *M*
buildSrc/src/main/groovy/org/elasticsearch/gradle/VersionProperties.groovy
<https://github.com/elastic/elasticsearch/pull/26704/files#diff-0> (2)
- *M* distribution/bwc/build.gradle
<https://github.com/elastic/elasticsearch/pull/26704/files#diff-1>
(20)
Patch Links:
- https://github.com/elastic/elasticsearch/pull/26704.patch
- https://github.com/elastic/elasticsearch/pull/26704.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#26704>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLomJafIDw8-k0rlmV5aDP_U_DlPtiks5sjzbagaJpZM4Pb0DQ>
.
|
This commit enforces bwc builds always generate snapshot versions, even when testing release versions in CI. closes elastic#26702
rjernst
force-pushed
the
release_test_bwc
branch
from
c5131db to
c41cfa6
Compare
Member
Author
|
I updated this to override the sysprops via the startParameter of GradleBuild, as suggested by @ywelsch. I'm willing to use this for now, but I am apprehensive about it because I know it means gradle is using |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 20, 2017
* master: [DOCS] Added index-shared4 and index-shared5.asciidoc BulkProcessor flush runnable preserves the thread context from creation time (elastic#26718) Catch exceptions and inform handler in RemoteClusterConnection#collectNodes (elastic#26725) [Docs] Fix name of character filter in example. (elastic#26724) Remove parse field deprecations in query builders (elastic#26711) elastic#26720: Set the correct bwc version after backport to 6.0 Remove deprecated type and slop field in MatchQueryBuilder (elastic#26720) Refactoring of Gateway*** classes (elastic#26706) Make RestHighLevelClient's Request class public (elastic#26627) Deguice ActionFilter (elastic#26691) aggs: Allow aggregation sorting via nested aggregation. Build: Set bwc builds to always set snapshot (elastic#26704) File Discovery: Remove fallback with zen discovery (elastic#26667)
rjernst
added a commit
that referenced
this pull request
Sep 25, 2017
This commit enforces bwc builds always generate snapshot versions, even when testing release versions in CI. closes #26702
rjernst
added a commit
that referenced
this pull request
Sep 25, 2017
This commit enforces bwc builds always generate snapshot versions, even when testing release versions in CI. closes #26702
rjernst
added a commit
that referenced
this pull request
Sep 25, 2017
This commit enforces bwc builds always generate snapshot versions, even when testing release versions in CI. closes #26702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the bwc builds use Exec instead of GradleBuild when
doing a release build. This is only relevant in the case of running
tests with a release build, which is only done by CI, so the sub build
in that case is run with info logging.
closes #26702