Remove reference to 32-bit systems. #25971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are not supported anymore as of elastic#25435.
jasontedor
approved these changes
Jul 31, 2017
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
I left one suggestion, I'm fine either way. LGTM.
| depending on the operating environment: `simplefs` on Windows 32bit, `niofs` | ||
| on other 32bit systems and `mmapfs` on 64bit systems. | ||
| depending on the operating environment, which is currently `mmapfs` on all | ||
| systems but is subject to change. |
Member
There was a problem hiding this comment.
Maybe add the word supported in front of systems?
Contributor
Author
There was a problem hiding this comment.
good idea, I'll do that
jpountz
added a commit
that referenced
this pull request
Jul 31, 2017
They are not supported anymore as of #25435.
jpountz
added a commit
that referenced
this pull request
Jul 31, 2017
They are not supported anymore as of #25435.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jul 31, 2017
* master: Remove memlock suggestion from systemd service Also skip JAVA_TOOL_OPTIONS on Windows Remove useless checks from evil JNA tests Add max file size bootstrap check Exit Windows scripts promptly on failure Remove another reference to 64-bit systems. Remove reference to 32-bit systems. (elastic#25971) No more using 'hybrid mmapfs / niofs' (elastic#25944)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are not supported anymore as of #25435.