No more using 'hybrid mmapfs / niofs' #25944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks a bit ambiguous here. ElasticSearch no more using 'hybrid mmapfs / niofs' which chooses filesystem based on the file. It is any one of the mmapfs, niofs or simplefs depending on the operating system. As quoted here https://www.elastic.co/guide/en/elasticsearch/reference/5.5/index-modules-store.html Thanks, Pulkit Agrawal
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jpountz
suggested changes
Jul 28, 2017
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
I requested a minor change.
| Elasticsearch uses a <<default_fs,`hybrid mmapfs / niofs`>> directory by | ||
| default to store its indices. The default operating system limits on mmap | ||
| Elasticsearch uses a <<default_fs,`mmapfs`>> directory by | ||
| default for 64bit systems to store its indices. The default operating system limits on mmap |
Contributor
There was a problem hiding this comment.
actually we do not support 32-bit systems so I think we can just say we use mmapfs all the time
Contributor
Author
There was a problem hiding this comment.
In that case, it will be required to change multiple places. The first will be on index-modules-store
https://www.elastic.co/guide/en/elasticsearch/reference/5.5/index-modules-store.html
Contributor
There was a problem hiding this comment.
This is a good call, I opened #25971. In the meantime I see your PR targets 5.5 where we still support 32-bit systems on a best-effort so I'll merge it as-is and just remove the 64-bit reference when merging to the 6.x/7.x branches.
jpountz
approved these changes
Jul 31, 2017
jpountz
pushed a commit
that referenced
this pull request
Jul 31, 2017
It looks a bit ambiguous here. ElasticSearch no more using 'hybrid mmapfs / niofs' which chooses filesystem based on the file. It is any one of the mmapfs, niofs or simplefs depending on the operating system. As quoted here https://www.elastic.co/guide/en/elasticsearch/reference/5.5/index-modules-store.html Thanks, Pulkit Agrawal
jpountz
pushed a commit
that referenced
this pull request
Jul 31, 2017
It looks a bit ambiguous here. ElasticSearch no more using 'hybrid mmapfs / niofs' which chooses filesystem based on the file. It is any one of the mmapfs, niofs or simplefs depending on the operating system. As quoted here https://www.elastic.co/guide/en/elasticsearch/reference/5.5/index-modules-store.html Thanks, Pulkit Agrawal
jpountz
pushed a commit
that referenced
this pull request
Jul 31, 2017
It looks a bit ambiguous here. ElasticSearch no more using 'hybrid mmapfs / niofs' which chooses filesystem based on the file. It is any one of the mmapfs, niofs or simplefs depending on the operating system. As quoted here https://www.elastic.co/guide/en/elasticsearch/reference/5.5/index-modules-store.html Thanks, Pulkit Agrawal
jpountz
pushed a commit
that referenced
this pull request
Jul 31, 2017
It looks a bit ambiguous here. ElasticSearch no more using 'hybrid mmapfs / niofs' which chooses filesystem based on the file. It is any one of the mmapfs, niofs or simplefs depending on the operating system. As quoted here https://www.elastic.co/guide/en/elasticsearch/reference/5.5/index-modules-store.html Thanks, Pulkit Agrawal
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jul 31, 2017
* master: Remove memlock suggestion from systemd service Also skip JAVA_TOOL_OPTIONS on Windows Remove useless checks from evil JNA tests Add max file size bootstrap check Exit Windows scripts promptly on failure Remove another reference to 64-bit systems. Remove reference to 32-bit systems. (elastic#25971) No more using 'hybrid mmapfs / niofs' (elastic#25944)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks a bit ambiguous here.
ElasticSearch no more using 'hybrid mmapfs / niofs' which chooses filesystem based on the file. It is any one of the mmapfs, niofs or simplefs depending on the operating system.
As quoted here https://www.elastic.co/guide/en/elasticsearch/reference/5.5/index-modules-store.html
Thanks,
Pulkit Agrawal
gradle check?