Allow custom service names when installing on windows #25255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
clintongormley
added
:Delivery/Packaging
Member
|
@russcam can you take a look at this PR? I think you're most familiar with the Windows service installation (if I am mistaken let me know if there's someone better suited) |
Member
Contributor
Author
|
@jasontedor done. |
Member
|
Thanks for the responsiveness. Now that we have a reviewable PR, my first question would be: what's the reason for wanting to customize the service name? I understand that the feature is documented, but it appears that it's never worked and this is the first time that has come up. |
* master: (891 commits) Remove potential nio selector leak (#27825) Add skip versions for rank_eval yaml tests Painless: Clean Up Painless Cast Object (#27794) Allow `_doc` as a type. (#27816) Clarify using supported LTS versions of the Java Fixes ByteSizeValue to serialise correctly (#27702) Mute VersionUtilsTest#testGradleVersionsMatchVersionUtils [Docs] Correct spelling in update-settings.asciidoc (#27808) Add unreleased v6.1.1 version Add rank-eval module to transport client and HL client dependencies [Docs] Fix explanation of "cluster.routing.allocation.exclude" (#27735) Use CountedBitSet in LocalCheckpointTracker (#27793) docs: fix link [Test] Fix MigrationDocumentationIT.testClusterHealth (#27774) Remove some unused code (#27792) remove stale comment in IndexShard TEST: Update translog gen of the last commit Keep commits and translog up to the global checkpoint (#27606) Use SPI to provide named XContent parsers for ranking evaluation Packaging test: add guard for too many files ...
jasontedor
pushed a commit
that referenced
this pull request
Dec 15, 2017
We document that users can set custom service names on Windows. Alas, the functionality does not work. This commit fixes the issue by passing the environment variable SERVICE_ID as the service name otherwise defaulting to elasticsearch-service-x64. Relates #25255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25231.