Clean Up Painless Cast Object #27794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equivalent Java class or the imported version of the Java class.
being boxed/unboxed.
rjernst
approved these changes
Dec 13, 2017
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
This looks fine as it is purely mechanical. I have one request.
| } | ||
|
|
||
| public static class Cast { | ||
| public static Cast standard(Type from, Type to, boolean explicit) { |
Member
There was a problem hiding this comment.
If we're going to have these helper methods, please at least give a one line javadoc explaining each one.
Contributor
Author
|
@elasticmachine test this please |
Contributor
Author
|
@rjernst Thanks for the review. |
jdconrad
added a commit
that referenced
this pull request
Dec 14, 2017
Added static methods to make creating Painless casts obvious as to what is being boxed/unboxed.
clintongormley
added
:Core/Infra/Scripting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds five static methods to the Cast object to make each type of cast easier to see within the code for unboxing/boxing.