Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,28 @@ task verifyVersions {
}
}

/*
* When adding backcompat behavior that spans major versions, temporarily
* disabling the backcompat tests is necessary. This flag controls
* the enabled state of every bwc task. It should be set back to true
* after the backport of the backcompat code is complete.
*/
allprojects {
ext.bwc_tests_enabled = true
}

task verifyBwcTestsEnabled {
doLast {
if (project.bwc_tests_enabled == false) {
throw new GradleException('Bwc tests are disabled. They must be re-enabled after completing backcompat behavior backporting.')
}
}
}

task branchConsistency {
description 'Ensures this branch is internally consistent. For example, that versions constants match released versions.'
group 'Verification'
dependsOn verifyVersions
dependsOn verifyVersions, verifyBwcTestsEnabled
}

subprojects {
Expand Down
8 changes: 6 additions & 2 deletions qa/full-cluster-restart/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,18 @@ for (Version version : indexCompatVersions) {
dependsOn = [upgradedClusterTest]
}

bwcTest.dependsOn(versionBwcTest)
if (project.bwc_tests_enabled == false) {
bwcTest.dependsOn(versionBwcTest)
}
}

test.enabled = false // no unit tests for rolling upgrades, only the rest integration test

// basic integ tests includes testing bwc against the most recent version
task integTest {
dependsOn = ["v${indexCompatVersions[-1]}#bwcTest"]
if (project.bwc_tests_enabled) {
dependsOn = ["v${indexCompatVersions[-1]}#bwcTest"]
}
}

check.dependsOn(integTest)
8 changes: 6 additions & 2 deletions qa/mixed-cluster/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,18 @@ for (Version version : wireCompatVersions) {
dependsOn = [mixedClusterTest]
}

bwcTest.dependsOn(versionBwcTest)
if (project.bwc_tests_enabled) {
bwcTest.dependsOn(versionBwcTest)
}
}

test.enabled = false // no unit tests for rolling upgrades, only the rest integration test

// basic integ tests includes testing bwc against the most recent version
task integTest {
dependsOn = ["v${wireCompatVersions[-1]}#bwcTest"]
if (project.bwc_tests_enabled) {
dependsOn = ["v${wireCompatVersions[-1]}#bwcTest"]
}
}

check.dependsOn(integTest)
9 changes: 7 additions & 2 deletions qa/rolling-upgrade/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -95,17 +95,22 @@ for (Version version : wireCompatVersions) {
}

Task versionBwcTest = tasks.create(name: "${baseName}#bwcTest") {
enabled = project.bwc_tests_enabled
dependsOn = [upgradedClusterTest]
}

bwcTest.dependsOn(versionBwcTest)
if (project.bwc_tests_enabled) {
bwcTest.dependsOn(versionBwcTest)
}
}

test.enabled = false // no unit tests for rolling upgrades, only the rest integration test

// basic integ tests includes testing bwc against the most recent version
task integTest {
dependsOn = ["v${wireCompatVersions[-1]}#bwcTest"]
if (project.bwc_tests_enabled) {
dependsOn = ["v${wireCompatVersions[-1]}#bwcTest"]
}
}

check.dependsOn(integTest)