Include empty mappings in GET /{index}/_mappings requests #25118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this would output:
```
GET /test-1/_mappings
{ }
```
And after this change:
```
GET /test-1/_mappings
{
"test-1": {
"mappings": {}
}
}
```
To bring parity back to the REST output after elastic#24723.
Relates to elastic#25090
Member
Author
|
(not marking this as breaking as this is "un-breaking" part of the 6.0 unreleased change from #24723) |
Member
Author
|
@jasontedor can you take a look at this one also? It's very small and related to #25114 |
jasontedor
approved these changes
Jun 8, 2017
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the REST test.
Member
Author
|
Thanks @jasontedor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this would output:
And after this change:
To bring parity back to the REST output after #24723.
Relates to #25090