Remove comma-separated feature parsing for GetIndicesAction #24723
Conversation
dakrone
added
:Core/Infra/REST API
dakrone
force-pushed
the
remove-comma-parsing-of-features
branch
3 times, most recently
from
8211d12 to
3ac55ad
Compare
|
@jasontedor could you take a look at this? This is the PR you asked me to separate from #24437 |
There was a problem hiding this comment.
This could just be changed to
GET twitter?filter_path=*.settings,*.mappingsThere was a problem hiding this comment.
I think we could, but not sure it's worth it since I think this is a very minor edge case that people use.
There was a problem hiding this comment.
/s/multiple information retrieval/retrieving multiple pieces of information
There was a problem hiding this comment.
Under what circumstances would the mappings for an index be null (as opposed to an empty map)? It seems the default for GetIndexResponse is to always have an empty map for mappings (and aliases and settings) and it would only get assigned to a non-null map.
There was a problem hiding this comment.
I don't think they ever would be, this is a carryover from when I copied this from the other method. I'll remove it.
There was a problem hiding this comment.
I'm not clear on why this test was eliminated, because we still support {index}/_mapping by its own without the comma-separated multi values?
There was a problem hiding this comment.
This test was eliminated because it was for the indices.get API, whereas we already have tests for the indices.get_mapping API (in another file), so this was just a duplicate test.
There was a problem hiding this comment.
Same about the duplicated test
There was a problem hiding this comment.
Same about the duplicated test :)
There was a problem hiding this comment.
Should we also add rest specs and yaml tests for the new REST endpoints introduced in this PR?
There was a problem hiding this comment.
Interestingly enough, we already do have these endpoints in the spec, they just weren't in this file :)
|
Thanks @abeyad, I pushed some commits addressing your feedback |
dakrone
force-pushed
the
remove-comma-parsing-of-features
branch
2 times, most recently
from
7577dc9 to
3581e37
Compare
This removes the parsing of things like `GET /idx/_aliases,_mappings`, instead, a user must choose between retriving all index metadata with `GET /idx`, or only a specific form such as `GET /idx/_settings`. Relates to (and is a prerequisite of) elastic#24437
dakrone
force-pushed
the
remove-comma-parsing-of-features
branch
from
3581e37 to
a32d1b9
Compare
|
thank you @abeyad :) |
|
Are we going to also deprecate this in 5.x? |
Good idea, I'll open a PR |
This is the deprecation logging and documentation for 5.x related to elastic#24723. It logs when a user does a request like: ``` GET /index/_alias,_mapping ```
* Add deprecation logging for comma-separated feature parsing This is the deprecation logging and documentation for 5.x related to #24723. It logs when a user does a request like: ``` GET /index/_alias,_mapping ```
Previously this would output:
```
GET /test-1/_mappings
{ }
```
And after this change:
```
GET /test-1/_mappings
{
"test-1": {
"mappings": {}
}
}
```
To bring parity back to the REST output after elastic#24723.
Relates to elastic#25090
Previously in elastic#24723 we changed the `_alias` API to not go through the `RestGetIndicesAction` endpoint, instead creating a `RestGetAliasesAction` that did the same thing. This changes the formatting so that it matches the old formatting of the endpoint, before: ``` GET /test-1/_alias { } ``` And after this change: ``` GET /test-1/_alias { "test-1": { "aliases": {} } } ``` This is related to elastic#25090
Removes dead code. Follow-up of #24723
Removes dead code. Follow-up of #24723
5 participants
This removes the parsing of things like
GET /idx/_aliases,_mappings, instead,a user must choose between retriving all index metadata with
GET /idx, or onlya specific form such as
GET /idx/_settings.Relates to (and is a prerequisite of) #24437