Skip to content

Conversation

@dadoonet
Copy link
Contributor

Today we have multiple ways to define settings when a user needs to create a repository:

  • in elasticsearch.yml file using repositories.azure prefix
  • when creating the repository itself with PUT _snaphot/repo

The plan is to:

Related to #22800

Today we have multiple ways to define settings when a user needs to create a repository:

* in `elasticsearch.yml` file using `repositories.azure` prefix
* when creating the repository itself with `PUT _snaphot/repo`

The plan is to:

* Deprecate `repositories.azure` settings in 5.x (done with elastic#22856)
* Remove in 6.x (this PR)

Related to elastic#22800
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@dadoonet
Copy link
Contributor Author

@rjernst Could you please review this? I'd like to merge it.

@dadoonet
Copy link
Contributor Author

@rjernst I'm planning to merge this one hopefully next week unless you see any blocker.

Copy link
Contributor

@s1monw s1monw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dadoonet dadoonet removed the request for review from rjernst March 31, 2017 10:31
@dadoonet dadoonet merged commit da907e7 into elastic:master Mar 31, 2017
@dadoonet dadoonet deleted the pr/remove-repositories-azure-settings branch March 31, 2017 10:36
@dadoonet
Copy link
Contributor Author

Thanks @s1monw!

@clintongormley clintongormley added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs and removed :Plugin Repository Azure labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>breaking :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v6.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants