Deprecate global repositories.azure settings
#22856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
dadoonet
added a commit
to dadoonet/elasticsearch
that referenced
this pull request
Jan 30, 2017
Similar to elastic#22843 but for azure Note that we need to add also this information to the deprecation documentation once it will be available (see elastic#22856).
Contributor
Author
|
Ping @rjernst |
Contributor
Author
|
@clintongormley So I removed the "deprecation" part in docs with 661ac38 and I will add them back in the breaking change section when I'll port this removal in master branch. @rjernst I'm planning to merge this PR on Monday if you don't have any objection. |
Today we have multiple ways to define settings when a user needs to create a repository: * in `elasticsearch.yml` file using `repositories.azure` prefix * when creating the repository itself with `PUT _snaphot/repo` The plan is to: * Deprecate `repositories.azure` settings in 5.x (this PR) * Remove in 6.x (master branch) Related to elastic#22800 Also adds a `deprecated` section in our docs as per elastic#22849.
dadoonet
force-pushed
the
pr/deprecate-repositories-azure-settings
branch
from
661ac38 to
26a2205
Compare
dadoonet
added a commit
to dadoonet/elasticsearch
that referenced
this pull request
Feb 20, 2017
Today we have multiple ways to define settings when a user needs to create a repository: * in `elasticsearch.yml` file using `repositories.azure` prefix * when creating the repository itself with `PUT _snaphot/repo` The plan is to: * Deprecate `repositories.azure` settings in 5.x (done with elastic#22856) * Remove in 6.x (this PR) Related to elastic#22800
This was referenced Feb 20, 2017
clintongormley
added
:Distributed Coordination/Snapshot/Restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we have multiple ways to define settings when a user needs to create a repository:
elasticsearch.ymlfile usingrepositories.azureprefixPUT _snaphot/repoThe plan is to:
repositories.azuresettings in 5.x (this PR)Related to #22800