Skip to content

Replace tika-files.zip by a tika-files dir #22963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2017
Merged

Replace tika-files.zip by a tika-files dir #22963

merged 2 commits into from
Feb 16, 2017

Conversation

@dadoonet
Copy link
Contributor

@dadoonet dadoonet commented Feb 3, 2017

Let's make our life easier when debugging/testing.
Also having a flat dir helps us to compare or "synchronize" more easily with Tika project files.

Related to #22958.
Same as of #22959 but for mapper-attachments plugin

@dadoonet
Replace tika-files.zip by a tika-files dir
03d5f97 
Let's make our life easier when debugging/testing.
Also having a flat dir helps us to compare or "synchronize" more easily with Tika project files.

Related to elastic#22958.
Same as of elastic#22959 but for mapper-attachments plugin
@dadoonet dadoonet added :Plugin Mapper Attachment >test Issues or PRs that are addressing/adding tests v5.3.0 labels Feb 3, 2017
@dadoonet dadoonet self-assigned this Feb 3, 2017
@dadoonet dadoonet requested a review from nik9000 February 3, 2017 15:45
@dadoonet dadoonet mentioned this pull request Feb 16, 2017
Merged
@dadoonet
Copy link
Contributor Author

dadoonet commented Feb 16, 2017 •
edited
Loading

@nik9000 ping. Could you look at this one please?
I'm planning to apply it to the same branches as we will have to apply #23214

@dadoonet dadoonet merged commit 19e59e1 into elastic:5.x Feb 16, 2017
@dadoonet
Copy link
Contributor Author

dadoonet commented Feb 16, 2017

Thanks @nik9000!

@dadoonet dadoonet deleted the pr/22959-mapper-attachments branch February 16, 2017 16:51
@dadoonet dadoonet removed the v5.2.2 label Feb 16, 2017
dadoonet added a commit that referenced this pull request Feb 16, 2017
@dadoonet
Replace tika-files.zip by a tika-files dir
22e8e29 
Backport of #22963 in 5.3 branch
dadoonet added a commit that referenced this pull request Feb 20, 2017
@dadoonet
Replace tika-files.zip by a tika-files dir
0561d1b 
Let's make our life easier when debugging/testing.
Also having a flat dir helps us to compare or "synchronize" more easily with Tika project files.

Related to #22958.
Same as of #22959 but for mapper-attachments plugin

Backport of #22963 in 5.2 branch
@clintongormley clintongormley added :Search Foundations/Mapping Index mappings, including merging and defining field types and removed :Plugin Mapper Attachment labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees

@dadoonet dadoonet

Labels

:Search Foundations/Mapping Index mappings, including merging and defining field types >test Issues or PRs that are addressing/adding tests v5.2.2 v5.3.0 v5.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dadoonet @nik9000 @clintongormley