Replace tika-files.zip by a tika-files dir #22959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's make our life easier when debugging/testing. Also having a flat dir helps us to compare or "synchronize" more easily with Tika project files. Closes elastic#22958.
dadoonet
added
:Plugin Ingest Attachment
>test
Contributor
Author
|
@nik9000 I'll do another similar PR for mapper attachments plugin in 5.x branch. |
Member
|
I like this idea because if we change one file we don't have to rewrite the whole zip.... Will review. |
nik9000
approved these changes
Feb 3, 2017
Contributor
Author
|
Thanks @nik9000 |
dadoonet
added a commit
to dadoonet/elasticsearch
that referenced
this pull request
Feb 3, 2017
Let's make our life easier when debugging/testing. Also having a flat dir helps us to compare or "synchronize" more easily with Tika project files. Related to elastic#22958. Same as of elastic#22959 but for mapper-attachments plugin
clintongormley
added
:Data Management/Ingest Node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make our life easier when debugging/testing.
Also having a flat dir helps us to compare or "synchronize" more easily with Tika project files.
Closes #22958.