S3 Repository: Remove region setting #22853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the ability to set region for s3 repositories. Endpoint should be used instead if a custom s3 location needs to be used. closes elastic#22758
dadoonet
approved these changes
Jan 29, 2017
Contributor
dadoonet
left a comment
dadoonet
left a comment
There was a problem hiding this comment.
It looks good. I just wonder why we added support for s3.client.*.region in the first place.
I believe we should not introduce an already deprecated setting in the first place, no?
Member
Author
I was not sure what the feedback would be at the time on removing region, and chose to follow up separately. We could remove it from 5.x, since it has not been released yet. |
Contributor
|
I see. Let's remove it then and change the doc then in this PR where we mention it. |
dadoonet
reviewed
Jan 30, 2017
| to securely store the credentials. | ||
|
|
||
| * Specifying region has been removed. This includes the settings `cloud.aws.region`, | ||
| `cloud.aws.s3.region`, `repositories.s3.region`, `s3.client.*.region` and specifying |
Contributor
There was a problem hiding this comment.
So just remove here
,
s3.client.*.region
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 16, 2017
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 16, 2017
gmarz
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 17, 2017
This was referenced Feb 24, 2017
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
clintongormley
added
:Distributed Coordination/Snapshot/Restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the ability to set region for s3 repositories.
Endpoint should be used instead if a custom s3 location needs to be
used.
closes #22758