Remove either endpoint or region setting in aws cloud plugins

[rjernst]

We have two different settings, endpoint and region, which determine the endpoint that is set on the aws client (and both of these appear unnecessary by default, as neither are required, and the s3 client appears to automatically find the region for a given bucket). My understanding is that it is useful to have an explicit setting to allow connecting to new regions without needing a new release. However, I don't think we need both settings? We should settle on one (I would think endpoint, and remove region altogether?).

[dadoonet]

I understand the goal of your proposal as it would remove some lines of code.
From a user point of view, I think it's easier to have that kind of feature where someone simply says:

region: eu-west-1

Instead of

endpoint: s3-eu-west-1.amazonaws.com

That said it's not really something you are doing all the time so I guess that we can just link from our documentation to S3 Regions.

Same for discovery-ec2 plugin: we could add a link from our documentation to EC2 regions.

So I don't have a strong opinion about it about removing region setting. For sure, I'd not remove endpoint.

[dadoonet]

Discussed on fix it friday: let's remove the region setting and keep only the endpoint which is much more flexible.