Skip to content

Add VirtualBox version check #21370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2016
Merged

Add VirtualBox version check #21370

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cccc4c
Add VirtualBox version check
tlrx Nov 7, 2016
571cdf5
Update after Jason comment
tlrx Nov 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions qa/vagrant/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,26 @@ task checkVagrantVersion(type: Exec) {
standardOutput = new ByteArrayOutputStream()
doLast {
String version = standardOutput.toString().trim()
if ((version ==~ /Vagrant 1\.[789]\..+/) == false) {
throw new InvalidUserDataException(
"Illegal version of vagrant [${version}]. Need [Vagrant 1.7+]")
if ((version ==~ /Vagrant 1\.(8\.[6-9]|9\.[0-9])+/) == false) {
throw new InvalidUserDataException("Illegal version of vagrant [${version}]. Need [Vagrant 1.8.6+]")
}
}
}

task checkVirtualBoxVersion(type: Exec) {
commandLine 'vboxmanage', '--version'
standardOutput = new ByteArrayOutputStream()
doLast {
String version = standardOutput.toString().trim()
try {
String[] versions = version.split('\\.')
int major = Integer.parseInt(versions[0])
int minor = Integer.parseInt(versions[1])
if ((major < 5) || (major == 5 && minor < 1)) {
throw new InvalidUserDataException("Illegal version of virtualbox [${version}]. Need [5.1+]")
}
} catch (NumberFormatException | ArrayIndexOutOfBoundsException e) {
throw new InvalidUserDataException("Unable to parse version of virtualbox [${version}]. Required [5.1+]", e)
}
}
}
Expand Down Expand Up @@ -247,7 +264,7 @@ for (String box : availableBoxes) {
Task update = tasks.create("vagrant${boxTask}#update", VagrantCommandTask) {
boxName box
args 'box', 'update', box
dependsOn checkVagrantVersion
dependsOn checkVagrantVersion, checkVirtualBoxVersion
}

Task up = tasks.create("vagrant${boxTask}#up", VagrantCommandTask) {
Expand Down