Add VirtualBox version check #21370
Merged
Add VirtualBox version check #21370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensure that VirtualBox is available in version 5.1+ in the system before running packaging tests. It also check for Vagrant version is now greater than 1.8.6.
tlrx
added
>test
nik9000
approved these changes
Nov 7, 2016
jasontedor
requested changes
Nov 7, 2016
qa/vagrant/build.gradle
Outdated
| standardOutput = new ByteArrayOutputStream() | ||
| doLast { | ||
| String version = standardOutput.toString().trim() | ||
| if ((version ==~ /5\.[1-9]\..+/) == false) { |
Member
There was a problem hiding this comment.
I think we should do something slightly different here. This will break if a new major release (major version 6) is made, and will also break if there is a minor release in the major release 5 series with minor version 10 or greater (e.g., 5.10). I think that we should parse the version into major/minor components and require that major >= 5 and if major == 5 then minor > 0.
Member
Author
There was a problem hiding this comment.
Right - there was versions like 5.0.26 in the past.
Member
Author
|
@jasontedor Thanks for the review. I updated the code. |
Member
Author
|
Thanks @jasontedor & @nik9000 ! |
tlrx
added a commit
that referenced
this pull request
Nov 10, 2016
This commit ensure that VirtualBox is available in version 5.1+ in the system before running packaging tests. It also check for Vagrant version is now greater than 1.8.6. (cherry picked from commit 4b94eb5)
Member
Author
|
5.x: 76a775c |
jasontedor
added a commit
that referenced
this pull request
Nov 11, 2016
* master: (516 commits) Avoid angering Log4j in TransportNodesActionTests Add trace logging when aquiring and releasing operation locks for replication requests Fix handler name on message not fully read Remove accidental import. Improve log message in TransportNodesAction Clean up of Script. Update Joda Time to version 2.9.5 (#21468) Remove unused ClusterService dependency from SearchPhaseController (#21421) Remove max_local_storage_nodes from elasticsearch.yml (#21467) Wait for all reindex subtasks before rethrottling Correcting a typo-Maan to Man-in README.textile (#21466) Fix InternalSearchHit#hasSource to return the proper boolean value (#21441) Replace all index date-math examples with the URI encoded form Fix typos (#21456) Adapt ES_JVM_OPTIONS packaging test to ubuntu-1204 Add null check in InternalSearchHit#sourceRef to prevent NPE (#21431) Add VirtualBox version check (#21370) Export ES_JVM_OPTIONS for SysV init Skip reindex rethrottle tests with workers Make forbidden APIs be quieter about classpath warnings (#21443) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensure that that VirtualBox is available in version 5.1+ in the system before running packaging tests. It also check for Vagrant version is now greater than 1.8.6.