Fix explain output for dfs query #19972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimczi
added
>bug
:Search/Search
Member
|
I gues this fix is correct, but can you please write a test for it? ;) |
Contributor
Author
|
Thanks @javanna. |
Member
There was a problem hiding this comment.
this last line is redundant I think, we already check the same above
Member
|
LGTM, but I am not too familiar with dfs so I would prefer @jpountz to have a quick second look. |
Contributor
|
LGTM! |
ContextIndexSearcher#explain ignores the dfs data to create the normalized weight. This change fixes this discrepancy by using the dfs data to create the normalized weight when needed.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContextIndexSearcher#explain ignores the dfs data to create the normalized weight.
This change fixes this discrepancy by using the dfs data to create the normalized weight when needed.
Fixes #15369