Predicate methods should provide question mark versions #134
Conversation
|
Passed for some failed for others due to curb. Looking at overall build_history it seems this is from other updates that were made not from this PR. |
|
Just wanted to follow up on this and see if anything else was necessary from me for this pull request or if there is an estimated timeline so I don't bug you all and follow up when it would be helpful rather than more randomly. Thanks for all your time and assistance :) |
|
Thanks for pinging me, Kevin! I got tied with something else, too tired to process it today, will look at it tomorrow morning! UPDATE: Yeah, the Curb driver failing is something I have to look into, it happens only in CI. |
|
No worries 👍 Didn't want to bug you as I know you are busy. Let me know if any changes need to be made though and I'll be happy to make adjustments as / if necessary |
To follow Ruby standards when returning a boolean value (eg. `Array#empty?`), added aliases for corresponding methods. Reference: * https://github.com/styleguide/ruby * http://pragmati.st/2012/03/24/the-elements-of-ruby-style-predicate-methods/ * http://raganwald.com/2013/09/12/the-predicate-module-pattern.html Closes: #134 Related: #133
|
I've merged the patch, Kevin, thanks! I've removed the extra test files and just added appropriate should test cases for method availability and identity. Once again here, sorry :) |
|
No worries. I appreciate the merge and your time reviewing it. |
2 participants
Alias all predicate methods per #133
Follow Ruby standards when returning a boolean value. This means the names of predicate methods (methods that return a boolean value) should end in a question mark. (i.e. Array#empty?).
Per:
https://github.com/styleguide/ruby
http://pragmati.st/2012/03/24/the-elements-of-ruby-style-predicate-methods/
http://raganwald.com/2013/09/12/the-predicate-module-pattern.html
Done using
alias_method