Predicate methods should end in a question mark #133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@kkirsche Good point! However, since we have a common API definition for all languages, these methods have to be added as an extra Ruby API. Can you change the pull request to do that? |
Contributor
Author
|
@karmi sure :) I'll just alias the existing methods exposing a new set. |
Contributor
|
@kkirsche Perfect!, thanks! |
Contributor
Author
|
Sorry, for some reason things broke when I tried to rollback my old commits so I made a new one as pull request #134 |
Contributor
|
@kkirsche No worries!, saw that, will look at that! |
karmi
pushed a commit
that referenced
this pull request
Feb 17, 2015
To follow Ruby standards when returning a boolean value (eg. `Array#empty?`), added aliases for corresponding methods. Reference: * https://github.com/styleguide/ruby * http://pragmati.st/2012/03/24/the-elements-of-ruby-style-predicate-methods/ * http://raganwald.com/2013/09/12/the-predicate-module-pattern.html Closes: #134 Related: #133
Contributor
|
I've merged the patch, Kevin, thanks! I've removed the extra test files and just added appropriate |
Contributor
Author
|
Awesome. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow Ruby standards when returning a boolean value. This means the names of predicate methods (methods that return a boolean value) should end in a question mark. (i.e. Array#empty?).
Per:
https://github.com/styleguide/ruby
http://pragmati.st/2012/03/24/the-elements-of-ruby-style-predicate-methods/
http://raganwald.com/2013/09/12/the-predicate-module-pattern.html