Add nori_number token filter in analysis-nori and discard_punctuation to filter #4591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
suggested changes
Apr 15, 2020
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
Left a comment about filters
| /// For example: "nori_number" - token filter normalizes Korean numbers to regular Arabic decimal numbers in half-width characters. | ||
| /// </summary> | ||
| [DataMember(Name = "filter")] | ||
| IEnumerable<string> Filters { get; set; } |
Contributor
There was a problem hiding this comment.
I think this should be removed. The token filters are applied at the analyzer level (level above tokenizer)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 17, 2020
Add discard_punctuation to nori token filter
github-actions bot
pushed a commit
that referenced
this pull request
Apr 17, 2020
Add discard_punctuation to nori token filter
codebrain
added a commit
that referenced
this pull request
Apr 17, 2020
Add discard_punctuation to nori token filter Co-authored-by: Stuart Cam <[email protected]>
codebrain
added a commit
that referenced
this pull request
Apr 17, 2020
Add discard_punctuation to nori token filter Co-authored-by: Stuart Cam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements elastic/elasticsearch/pull/53583