Remove filter from tokenizer and push up to analyzer

Author: codebrain

src/Nest/Analysis/Analyzers/NoriAnalyzer.cs

@@ -8,6 +8,7 @@ namespace Nest
 	/// <para> - nori_tokenizer</para>
 	/// <para> - nori_part_of_speech token filter</para>
 	/// <para> - nori_readingform token filter</para>
+	/// <para> - nori_number token filter</para>
 	/// <para> - lowercase token filter</para>
 	/// </summary>
 	public interface INoriAnalyzer : IAnalyzer

src/Nest/Analysis/Tokenizers/NoriTokenizer.cs

@@ -53,13 +53,6 @@ public interface INoriTokenizer : ITokenizer
 		/// </remarks>
 		[DataMember(Name = "user_dictionary_rules")]
 		IEnumerable<string> UserDictionaryRules { get; set; }
-
-		/// <summary>
-		/// Filters to apply to this tokenizer.
-		/// For example:  "nori_number" - token filter normalizes Korean numbers to regular Arabic decimal numbers in half-width characters.
-		/// </summary>
-		[DataMember(Name = "filter")]
-		IEnumerable<string> Filters { get; set; }
 	}
 
 	/// <inheritdoc cref="INoriTokenizer" />
@@ -78,9 +71,6 @@ public class NoriTokenizer : TokenizerBase, INoriTokenizer
 
 		/// <inheritdoc cref="INoriTokenizer.UserDictionaryRules" />
 		public IEnumerable<string> UserDictionaryRules { get; set; }
-
-		/// <inheritdoc cref="INoriTokenizer.Filters" />
-		public IEnumerable<string> Filters { get; set; }
 	}
 
 	/// <inheritdoc cref="INoriTokenizer" />
@@ -93,7 +83,6 @@ public class NoriTokenizerDescriptor
 		string INoriTokenizer.UserDictionary { get; set; }
 		IEnumerable<string> INoriTokenizer.UserDictionaryRules { get; set; }
 		bool? INoriTokenizer.DiscardPunctuation { get; set; }
-		IEnumerable<string> INoriTokenizer.Filters { get; set; }
 
 		/// <inheritdoc cref="INoriTokenizer.DecompoundMode" />
 		public NoriTokenizerDescriptor DecompoundMode(NoriDecompoundMode? mode) => Assign(mode, (a, v) => a.DecompoundMode = v);
@@ -109,8 +98,5 @@ public class NoriTokenizerDescriptor
 
 		/// <inheritdoc cref="INoriTokenizer.DiscardPunctuation" />
 		public NoriTokenizerDescriptor DiscardPunctuation(bool? discard = true) => Assign(discard, (a, v) => a.DiscardPunctuation = v);
-
-		/// <inheritdoc cref="INoriTokenizer.Filters" />
-		public NoriTokenizerDescriptor Filters(IEnumerable<string> filters) => Assign(filters, (a, v) => a.Filters = v);
 	}
 }

tests/Tests/Analysis/Tokenizers/TokenizerTests.cs

@@ -348,21 +348,5 @@ public class DiscardPunctuationTests : TokenizerAssertionBase<DiscardPunctuation
 			public override object Json => new { type = "nori_tokenizer", discard_punctuation = true };
 			public override string Name => "nori";
 		}
-
-		[SkipVersion("<7.7.0", "filter introduced in 7.7.0")]
-		public class FilterTests : TokenizerAssertionBase<FilterTests>
-		{
-			public override FuncTokenizer Fluent => (n, t) => t.Nori(n, e => e
-				.Filters(new [] { "nori_number" })
-			);
-
-			public override ITokenizer Initializer => new NoriTokenizer
-			{
-				Filters = new [] { "nori_number" }
-			};
-
-			public override object Json => new { type = "nori_tokenizer", filter = new[] { "nori_number" } };
-			public override string Name => "nori";
-		}
 	}
 }