Create exception formatters for different exceptions #4378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the ExceptionFormatterResolver to return a new instance of the now generic ExceptionFormatter<TException> for the type of exception. This fixes a bug where an ExceptionFormatter of type IJsonFormatter<Exception> is returned for derived exception types, resulting in an InvalidCastException at runtime. Formatter instances created are cached in ElasticsearchNetFormatterResolver for the type T, so will be reused once created. Fixes #4294
Mpdreamz
requested changes
Feb 10, 2020
| if (typeof(Exception).IsAssignableFrom(typeof(T))) | ||
| return (IJsonFormatter<T>)ExceptionFormatter; | ||
| { | ||
| var type = typeof(ExceptionFormatter<>).MakeGenericType(typeof(T)); |
Contributor
Author
There was a problem hiding this comment.
CreateGenericInstance exists in Nest, but ExceptionFormatter is in Elasticsearch.Net. Can move the extension method to Elasticsearch.Net?
Member
There was a problem hiding this comment.
I think we can, we can also follow up in a new issue.
Contributor
Author
|
ported to master 2d63ce0 |
russcam
added a commit
that referenced
this pull request
Feb 12, 2020
This commit changes the ExceptionFormatterResolver to return a new instance of the now generic ExceptionFormatter<TException> for the type of exception. This fixes a bug where an ExceptionFormatter of type IJsonFormatter<Exception> is returned for derived exception types, resulting in an InvalidCastException at runtime. Formatter instances created are cached in ElasticsearchNetFormatterResolver for the type T, so will be reused once created. Fixes #4294 (cherry picked from commit 8156ea7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the ExceptionFormatterResolver to return a new instance
of the now generic ExceptionFormatter for the type of exception.
This fixes a bug where an ExceptionFormatter of type IJsonFormatter
is returned for derived exception types, resulting in an InvalidCastException
at runtime.
Formatter instances created are cached in ElasticsearchNetFormatterResolver
for the type T, so will be reused once created.
Fixes #4294