Create exception formatters for different exceptions (#4378)

This commit changes the ExceptionFormatterResolver to return a new instance
of the now generic ExceptionFormatter<TException> for the type of exception.
This fixes a bug where an ExceptionFormatter of type IJsonFormatter<Exception>
is returned for derived exception types, resulting in an InvalidCastException
at runtime.

Formatter instances created are cached in ElasticsearchNetFormatterResolver
for the type T, so will be reused once created.

Fixes #4294

Author: russcam

src/Elasticsearch.Net/Serialization/Formatters/ExceptionFormatter.cs

@@ -3,30 +3,32 @@
 using System.Globalization;
 using System.Reflection;
 using System.Runtime.Serialization;
+using Elasticsearch.Net.Extensions;
 using Elasticsearch.Net.Utf8Json;
 
 namespace Elasticsearch.Net
 {
 	internal class ExceptionFormatterResolver : IJsonFormatterResolver
 	{
-		public static ExceptionFormatterResolver Instance = new ExceptionFormatterResolver();
+		public static readonly ExceptionFormatterResolver Instance = new ExceptionFormatterResolver();
 
 		private ExceptionFormatterResolver() { }
 
-		private static readonly ExceptionFormatter ExceptionFormatter = new ExceptionFormatter();
-
 		public IJsonFormatter<T> GetFormatter<T>()
 		{
 			if (typeof(Exception).IsAssignableFrom(typeof(T)))
-				return (IJsonFormatter<T>)ExceptionFormatter;
+			{
+				var type = typeof(ExceptionFormatter<>).MakeGenericType(typeof(T));
+				return (IJsonFormatter<T>)type.CreateInstance();
+			}
 
 			return null;
 		}
 	}
 
-	internal class ExceptionFormatter : IJsonFormatter<Exception>
+	internal class ExceptionFormatter<TException> : IJsonFormatter<TException> where TException : Exception
 	{
-		private List<Dictionary<string, object>> FlattenExceptions(Exception e)
+		private static List<Dictionary<string, object>> FlattenExceptions(Exception e)
 		{
 			var maxExceptions = 20;
 			var exceptions = new List<Dictionary<string, object>>(maxExceptions);
@@ -100,7 +102,7 @@ private static void WriteStructuredExceptionMethod(Dictionary<string,object> o,
 			o.Add("ExceptionMethod", exceptionMethod);
 		}
 
-		public void Serialize(ref JsonWriter writer, Exception value, IJsonFormatterResolver formatterResolver)
+		public void Serialize(ref JsonWriter writer, TException value, IJsonFormatterResolver formatterResolver)
 		{
 			if (value == null)
 			{
@@ -134,7 +136,7 @@ public void Serialize(ref JsonWriter writer, Exception value, IJsonFormatterReso
 			writer.WriteEndArray();
 		}
 
-		public Exception Deserialize(ref JsonReader reader, IJsonFormatterResolver formatterResolver) =>
+		public TException Deserialize(ref JsonReader reader, IJsonFormatterResolver formatterResolver) =>
 			throw new NotSupportedException();
 	}
 }

tests/Tests.Reproduce/GitHubIssue4294.cs

@@ -0,0 +1,28 @@
+using System;
+using System.Collections.Generic;
+using System.IO;
+using Elastic.Xunit.XunitPlumbing;
+using Elasticsearch.Net;
+using FluentAssertions;
+
+namespace Tests.Reproduce
+{
+	public class GitHubIssue4294
+	{
+		[U] public void CanSerializeNullReferenceException()
+		{
+			var settings = new ConnectionConfiguration();
+
+			var dic = new Dictionary<string, object>()
+			{
+				["Exception"] = new NullReferenceException(),
+			};
+
+			var data = PostData.Serializable(dic);
+			using var ms = new MemoryStream();
+			Action write = () => data.Write(ms, settings);
+
+			write.Should().NotThrow();
+		}
+	}
+}