Only run IL rewriting target when releasing or on CI #4031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the internalize-dependencies target to only run when Not Mono AND either running on CI OR building release Closes #3674
Mpdreamz
requested changes
Aug 20, 2019
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
member this.MergeDependencies=
match this with
| Project Nest -> [Project Project.Nest; ]
| _ -> []
Projects.fs lists the following still for Nest, should probably return empty array for everything.
This commit updates the Elastic Abstractions dependencies to pick up the change elastic/elasticsearch-net-abstractions@09c10a7
This commit removes build code that was used to IL merge Json.NET as it is no longer relevant
Contributor
Author
|
I've added some additional changes to remove references to IL merging Json.NET. @Mpdreamz, would you be able to take another look please? |
Mpdreamz
approved these changes
Sep 23, 2019
Member
|
LGTM, sorry for leaving this lingering 👍 |
Missed in merge
Contributor
Author
|
ported to 7.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the internalize-dependencies target to only run when
Not Mono AND either running on CI OR building release
Closes #3674