-
Notifications
You must be signed in to change notification settings - Fork 347
Updates conf.yaml refs to include 8.10 branch #2743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @benironside! Can you update or rebase this branch to include changes from #2742? We'll want to add the 8.10 branch for that new book as well. |
|
The current build error:
... indicates that this repo doesn't have an 8.10 branch yet: https://github.com/elastic/elasticsearch-php To solve that error, we can update the |
|
@elasticmachine run elasticsearch-ci/docs rebuild |
|
Hey @benironside — I pushed |
|
@elasticmachine run elasticsearch-ci/docs rebuild |
|
The current build errors are ones I can recreate locally by checking out 8.10 and building the security guide:
Per discussion with @benironside these seem to be caused by problems in https://github.com/elastic/security-docs/blob/8.10/docs/detections/prebuilt-rules/[…]oadable-packages/8-10-1/prebuilt-rules-8-10-1-appendix.asciidoc (tries to include non-existent file) and https://github.com/elastic/security-docs/blob/8.10/docs/detections/prebuilt-rules/rule-details/enumerating-domain-trusts-via-nltest-exe.asciidoc (is a target of links but isn't published since it doesn't seem to be in any nav files). |
|
@benironside - As we discussed, the issue is caused by incorrect file names and links to non-existent docs which derive from a security docs generation bug in our existing workflow. Apologies for this. Here is a bug issue for our repo to have this fixed on our end to avoid this issue in the future: elastic/detection-rules#3032 |
|
It looks like the Lang Clients team have created the 8.10 branches. I'm going to re-add those in the meantime. |
|
@elasticmachine run elasticsearch-ci/docs |
|
@elasticmachine run elasticsearch-ci/docs rebuild |
|
@elasticmachine run elasticsearch-ci/docs |
lcawl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks so much for getting this over the finish line @lcawl. 🏁 |
This PR adds 8.10 branches to the conf.yaml file.