Add TLS support (#186)

[xenia-lang]

This is a suggestion for fixing #186.

[cla-checker-service]

💚 CLA has been signed

[ghost]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-01-17T00:48:57.018+0000

• Duration: 5 min 21 sec

Test stats 🧪

Test	Results
Failed	0
Passed	208
Skipped	2
Total	210

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[xenia-lang]

I am confused by the contributor agreement. It says that the field "Title" is required. What am I supposed to put in there?

[xenia-lang]

/test

[axw]

Thanks @JonathanLang-TNG! Looks good, I'd just like to align the env var names with the ones used by Elastic APM agents.

Would you mind adding a couple of basic unit tests? For now I think it would be enough to test just the certificate PEM & verify certs config. You could clone TestInfoProxy and use httptest.NewTLSServer, then check that the proxy code can connect with either verification disabled, or by passing the server's self-signed certificate as the CA cert.

[axw]

LGTM. Thank you!

[axw]

/test

[axw]

run elasticsearch-ci/docs

[axw]

@JonathanLang-TNG please run go mod tidy to get CI to pass.

[xenia-lang]

Would be really helpful if I could trigger the CI, so I can check myself if everything is fine...

[axw]

/test

[axw]

Thanks again @JonathanLang-TNG!

[xenia-lang]

@axw Do you have any idea, when these changes will make into the lambda layer elastic provides on AWS? So, when the next release will be?

[axw]

Typically we create new releases in alignment with the Elastic stack. I'll discuss with the team and see if we have capacity to do some manual testing before 8.7.0 is due, and get back to you.

[axw]

@JonathanLang-TNG we will look at testing and creating a new release soon (sooner than 8.7.0; hopefully in the next couple of weeks, but I can't promise): #364

[axw]

@JonathanLang-TNG apologies for the delay, we have just released this in v1.3.0