Skip to content

build: update notice to 2023 #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2023
Merged

build: update notice to 2023 #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NOTICE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright 2022 Elasticsearch BV
Copyright 2023 Elasticsearch BV
Copy link
Contributor

@marclop marclop Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be 2022-2023?

Suggested change
Copyright 2023 Elasticsearch BV
Copyright 2022-2023 Elasticsearch BV

Copy link
Member Author

@kruskall kruskall Jan 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, the template says currentYear:

apm-aws-lambda/scripts/templates/NOTICE.txt.tmpl

Line 13 in 3032883

Copyright {{ currentYear }} Elasticsearch BV

Copy link
Member Author

@kruskall kruskall Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what we're doing in other repositories. It might be worth to look into it and make it more consistent

Copy link
Contributor

@marclop marclop Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The APM Server used that format, that's why I was suggesting we use that format here as well.

Copy link
Member Author

@kruskall kruskall Jan 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked at a few repositories and I think the lambda extension is the only one using currentYear. I'll gather more data and open a followup issue/PR.

Thanks for pointing this out! 🙇


Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down