Skip to content

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Jan 1, 2023

It's 2023 🎉

CI is failing because the year is not up to date.

@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jan 1, 2023
@ghost
Copy link

ghost commented Jan 1, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-01T18:46:48.741+0000

  • Duration: 5 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 204
Skipped 2
Total 206

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kruskall kruskall requested a review from a team January 3, 2023 00:53
@@ -1,4 +1,4 @@
Copyright 2022 Elasticsearch BV
Copyright 2023 Elasticsearch BV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be 2022-2023?

Suggested change
Copyright 2023 Elasticsearch BV
Copyright 2022-2023 Elasticsearch BV

Copy link
Member Author

@kruskall kruskall Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, the template says currentYear:

Copyright {{ currentYear }} Elasticsearch BV

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what we're doing in other repositories. It might be worth to look into it and make it more consistent

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The APM Server used that format, that's why I was suggesting we use that format here as well.

Copy link
Member Author

@kruskall kruskall Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked at a few repositories and I think the lambda extension is the only one using currentYear. I'll gather more data and open a followup issue/PR.

Thanks for pointing this out! 🙇

@kruskall kruskall merged commit b813751 into elastic:main Jan 3, 2023
@kruskall kruskall deleted the build/notice-2023 branch January 3, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants