-
Notifications
You must be signed in to change notification settings - Fork 35
build: update notice to 2023 #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1,4 +1,4 @@ | |||
Copyright 2022 Elasticsearch BV | |||
Copyright 2023 Elasticsearch BV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be 2022-2023
?
Copyright 2023 Elasticsearch BV | |
Copyright 2022-2023 Elasticsearch BV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, the template says currentYear
:
Copyright {{ currentYear }} Elasticsearch BV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what we're doing in other repositories. It might be worth to look into it and make it more consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The APM Server used that format, that's why I was suggesting we use that format here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked at a few repositories and I think the lambda extension is the only one using currentYear
. I'll gather more data and open a followup issue/PR.
Thanks for pointing this out! 🙇
It's 2023 🎉
CI is failing because the year is not up to date.