Added docs section for using secrets manager with the extension #222

AlexanderWert · 2022-06-20T13:56:25Z

Closes #211

simitt

Haven't specifically tested, but the docs look good and straight forward to follow.

ghost · 2022-06-20T14:59:56Z

❕ Build Aborted

Either there was a build timeout or someone aborted the build.

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-06-21T05:33:49.412+0000
Duration: 63 min 56 sec

Test stats 🧪

Test	Results
Failed	0
Passed	110
Skipped	2
Total	112

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

bmorelli25

Nice! Very easy to follow. I have a few recommendations—most are grammar-related. In addition, I have some recommendations to use code callouts instead of comments.

docs/monitoring-aws-lambda.asciidoc

docs/secrets-manager/add-permissions-content.asciidoc

docs/secrets-manager/create-secret-content.asciidoc

Co-authored-by: Brandon Morelli <[email protected]>

…tic#222) * Added docs section for using secrets manager with the extension * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/create-secret-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/create-secret-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/create-secret-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> Co-authored-by: Brandon Morelli <[email protected]> (cherry picked from commit fbf9f7a)

…tic#222) * Added docs section for using secrets manager with the extension * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/create-secret-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/create-secret-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/create-secret-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> Co-authored-by: Brandon Morelli <[email protected]> (cherry picked from commit fbf9f7a) # Conflicts: # docs/monitoring-aws-lambda.asciidoc

bmorelli25 · 2022-06-21T14:27:55Z

💚 All backports created successfully

Status	Branch	Result
✅	8.3
✅	8.2

Questions ?

Please refer to the Backport tool documentation

#223) * Added docs section for using secrets manager with the extension * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/create-secret-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/create-secret-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/create-secret-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> Co-authored-by: Brandon Morelli <[email protected]> (cherry picked from commit fbf9f7a) Co-authored-by: Alexander Wert <[email protected]>

#224) * Added docs section for using secrets manager with the extension * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/monitoring-aws-lambda.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/create-secret-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/create-secret-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/create-secret-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> * Update docs/secrets-manager/add-permissions-content.asciidoc Co-authored-by: Brandon Morelli <[email protected]> Co-authored-by: Brandon Morelli <[email protected]> (cherry picked from commit fbf9f7a) # Conflicts: # docs/monitoring-aws-lambda.asciidoc Co-authored-by: Alexander Wert <[email protected]>

Added docs section for using secrets manager with the extension

0d64787

AlexanderWert requested a review from bmorelli25 June 20, 2022 13:56

github-actions bot added the aws-λ-extension AWS Lambda Extension label Jun 20, 2022

simitt approved these changes Jun 20, 2022

View reviewed changes

bmorelli25 added v8.2.0 v8.3.0 needs-backport labels Jun 20, 2022

bmorelli25 reviewed Jun 20, 2022

View reviewed changes

AlexanderWert and others added 13 commits June 21, 2022 07:27

Update docs/monitoring-aws-lambda.asciidoc

12ca1ab

Co-authored-by: Brandon Morelli <[email protected]>

Update docs/monitoring-aws-lambda.asciidoc

cc6460c

Co-authored-by: Brandon Morelli <[email protected]>

Update docs/monitoring-aws-lambda.asciidoc

f64c4bd

Co-authored-by: Brandon Morelli <[email protected]>

Update docs/monitoring-aws-lambda.asciidoc

3df16ad

Co-authored-by: Brandon Morelli <[email protected]>

Update docs/monitoring-aws-lambda.asciidoc

cb98730

Co-authored-by: Brandon Morelli <[email protected]>

Update docs/secrets-manager/create-secret-content.asciidoc

8602230

Co-authored-by: Brandon Morelli <[email protected]>

Update docs/secrets-manager/create-secret-content.asciidoc

da9f7bd

Co-authored-by: Brandon Morelli <[email protected]>

Update docs/secrets-manager/add-permissions-content.asciidoc

1d7261c

Co-authored-by: Brandon Morelli <[email protected]>

Update docs/secrets-manager/add-permissions-content.asciidoc

2e3c923

Co-authored-by: Brandon Morelli <[email protected]>

Update docs/secrets-manager/create-secret-content.asciidoc

4703ba9

Co-authored-by: Brandon Morelli <[email protected]>

Update docs/secrets-manager/add-permissions-content.asciidoc

212e269

Co-authored-by: Brandon Morelli <[email protected]>

Update docs/secrets-manager/add-permissions-content.asciidoc

af1b8f5

Co-authored-by: Brandon Morelli <[email protected]>

Update docs/secrets-manager/add-permissions-content.asciidoc

6f98836

Co-authored-by: Brandon Morelli <[email protected]>

AlexanderWert merged commit fbf9f7a into elastic:main Jun 21, 2022

bmorelli25 mentioned this pull request Jun 21, 2022

[8.3] Added docs section for using secrets manager with the extension (#222) #223

Merged

bmorelli25 mentioned this pull request Jun 21, 2022

[8.2] Added docs section for using secrets manager with the extension (#222) #224

Merged

bmorelli25 removed the needs-backport label Jun 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added docs section for using secrets manager with the extension #222

Added docs section for using secrets manager with the extension #222

Uh oh!

AlexanderWert commented Jun 20, 2022

Uh oh!

simitt left a comment

Uh oh!

ghost commented Jun 20, 2022 •

edited by ghost

Loading

Build stats

Test stats 🧪

Uh oh!

bmorelli25 left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bmorelli25 commented Jun 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Added docs section for using secrets manager with the extension #222

Added docs section for using secrets manager with the extension #222

Uh oh!

Conversation

AlexanderWert commented Jun 20, 2022

Uh oh!

simitt left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Jun 20, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❕ Build Aborted

Build stats

Test stats 🧪

🤖 GitHub comments

Uh oh!

bmorelli25 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bmorelli25 commented Jun 21, 2022

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ghost commented Jun 20, 2022 •

edited by ghost

Loading

bmorelli25 left a comment •

edited

Loading