Skip to content

Conversation

@jlvoiseux
Copy link
Contributor

@jlvoiseux jlvoiseux commented Mar 30, 2022

Motivation / Summary

The goal of this pull request is to bump the minimum Go version supported by the extension codebase to 1.17. This bump has the following perks:

  • Alignment with the APM Server
  • Resolve make check-licenses fails #163, tied to the check-licenses, update-licenses and lint make targets. These targets rely on the use of go install outside of a module-aware context, which is only fully possible as of Go 1.17.
  • Ease the implementation of the metrics, as Unix.Milliseconds() and Unix.Microseconds() are only available in Go 1.17 (see commits 577e296 and c8e23cb).

This PR aims to track the discussion / changes necessary to perform the bump. The .Jenkinsfile and go.mod have been updated in the initial commits.

@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Mar 30, 2022
@ghost
Copy link

ghost commented Mar 30, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-30T16:26:35.222+0000

  • Duration: 7 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 160
Skipped 4
Total 164

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jlvoiseux jlvoiseux marked this pull request as ready for review March 30, 2022 16:34
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not an experience go dev. :)

@jlvoiseux jlvoiseux requested a review from estolfo April 4, 2022 09:08
@jlvoiseux jlvoiseux requested a review from a team April 4, 2022 13:39
@jlvoiseux jlvoiseux merged commit d81358c into elastic:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make check-licenses fails

4 participants