`make check-licenses` fails

[trentm]

% make check-licenses
go install github.com/elastic/go-licenser@v0.4.0
go run github.com/elastic/go-licenser@v0.4.0 -d .
package github.com/elastic/go-licenser@v0.4.0: can only use path@version syntax with 'go get' and 'go install' in module-aware mode
make: *** [check-licenses] Error 1

My golang ignorance means I don't immediately know what to do about "module-aware mode".

I'm using go 1.16:

% go version
go version go1.16.3 darwin/amd64

which I think is acceptable given go 1.14 in "go.mod". What is the min golang version for the extension?

[jlvoiseux]

Nice catch ! Thanks for the heads-up.

I able able to reproduce by setting GO111MODULE=off. According to the docs, https://tip.golang.org/doc/go1.16#modules, the Module Aware mode should be enabled by default for people using Go >= 1.16. Seems like it is not the case for you. The quickest fix is to set GO111MODULE=on.

Something that we can do is to force this option on in the makefile. This might be reasonable, as many of the used go commands require the Module-Aware mode to be enabled. I will open a PR to do so, feel free to use it and see if it solves the issues.

[trentm]

Jean-Louis and I discussed for a while. With go1.16.x the go run ... command cannot handling @version on the go package argument. From https://maelvls.dev/go111module-everywhere/#go-run-knows-about-version-finally

# Before Go 1.17:
go get github.com/golang/mock/mockgen@v1.3.1
go run -mod=mod github.com/golang/mock/mockgen

# With Go 1.17:
go run github.com/golang/mock/mockgen@v1.3.1

The following would be a fix (at least for Go 1.16 usage, I'm not sure about back to Go 1.14 -- the version currently in "go.mod"):

--- a/apm-lambda-extension/Makefile
+++ b/apm-lambda-extension/Makefile
@@ -16,8 +16,8 @@ endif
 export AWS_FOLDER GOARCH ARCHITECTURE

 check-licenses:
-       go install github.com/elastic/go-licenser@v0.4.0
-       go run github.com/elastic/go-licenser@v0.4.0 -d .
+       GO111MODULE=on go install github.com/elastic/go-licenser@v0.4.0
+       go run -mod=mod github.com/elastic/go-licenser -d .

 update-licenses:
        go install github.com/elastic/go-licenser@v0.4.0

However, we'd need this kind of change for a couple other Makefile targets.
We are stopping here, because we both think updating the base go version in "go.mod" to 1.17 is the way to go. It fixes this issue and brings other Go features that will be useful for coming work.