Skip to content

Conversation

trentm
Copy link
Member

@trentm trentm commented Mar 5, 2022

Closes: #141

Checklist

@trentm trentm self-assigned this Mar 5, 2022
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Mar 5, 2022
@ghost
Copy link

ghost commented Mar 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-05T01:00:06.775+0000

  • Duration: 7 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 84
Skipped 6
Total 90

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm
Copy link
Member Author

trentm commented Mar 5, 2022

Tested via:

% ELASTIC_LAYER_NAME=trentm-test-elastic-apm-extension make build-and-publish
GOARCH=amd64 make build
GOOS=linux go build -o bin/extensions/apm-lambda-extension main.go
chmod +x bin/extensions/apm-lambda-extension
GOARCH=amd64 make zip
cd bin && rm -f extension.zip || true && zip -r extension.zip extensions && cp extension.zip amd64.zip
  adding: extensions/ (stored 0%)
  adding: extensions/apm-lambda-extension (deflated 47%)
/Applications/Xcode.app/Contents/Developer/usr/bin/make publish
{
    "Content": {
        "Location": "https://awslambda-us-west-2-layers.s3.us-west-2.amazonaws.com/snapshots/627286350134/trentm-test-elastic-apm-extension-x86_64-cd6...",
        "CodeSha256": "4BIzlFiYmhP5DJh54NPAqENE4CECYFv3oxxK15KxICY=",
        "CodeSize": 3841979
    },
    "LayerArn": "arn:aws:lambda:us-west-2:627286350134:layer:trentm-test-elastic-apm-extension-x86_64",
    "LayerVersionArn": "arn:aws:lambda:us-west-2:627286350134:layer:trentm-test-elastic-apm-extension-x86_64:1",
    "Description": "AWS Lambda Extension Layer for Elastic APM x86_64",
    "CreatedDate": "2022-03-05T00:56:13.939+0000",
    "Version": 1,
    "LicenseInfo": "Apache-2.0",
    "CompatibleArchitectures": [
        "x86_64"
    ]
}

which now properly includes a "CompatibleArchitectures" value.

In the console this looks like:
Screen Shot 2022-03-04 at 4 57 01 PM

Aside: The AWS Console doesn't actually warn at all if you attempt to add a layer with "Compatible architectures: x86_64" to a Lambda function with "Architecture: arm64". Not great, but not our issue. :)

@trentm trentm requested review from estolfo and v1v March 5, 2022 01:04
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

If needed, we could publish a new version with this fix for the same Release (if it makes any sense) those ARNs will be bumped

@trentm
Copy link
Member Author

trentm commented Mar 7, 2022

If needed, we could publish a new version with this fix for the same Release (if it makes any sense)

No need. We want a new version release with #132 when that goes in (hopefully soon), anyway.

@trentm trentm merged commit f6fd3b1 into main Mar 7, 2022
@trentm trentm deleted the trentm/ext-compat-archs branch March 7, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

published extension layers should set "Compatible architectures"

2 participants