-
Notifications
You must be signed in to change notification settings - Fork 35
Address partial list of code review comments #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! made some comments but i think they're mostly cosmetic
FYI: When testing with a build of the extension using this branch and with the Node.js APM agent changes to send the |
Thanks for the update @trentm. This change should have indeed fixed that panic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
99501f3
to
efb4054
Compare
This PR addresses some comments from this code review: #124 (comment)
Todo (3 March)