publish: add elastic prefix in the layer name and version as suffix #115
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Co-authored-by: Felix Barnsteiner <[email protected]>
|
@v1v I think we also need the architecture key as a suffix in the layer name, otherwise the ARNs will be identical for the two different architectures (which is not possible --> so would result just in two different layer versions, which is confusing) |
| deleteDir() | ||
| gitCheckout(basedir: "${BASE_DIR}") | ||
| stash allowEmpty: true, name: 'source', useDefaultExcludes: false | ||
| setEnvVar('ELASTIC_LAYER_NAME', "elastic-apm-extension${getVersion()}") |
There was a problem hiding this comment.
I think we need to include a suffix for the architecture, otherwise the ARNs for x86_64 and arm64 are indistinguishable.
…ambda into feature/publishing-changes * 'feature/publishing-changes' of github.com:v1v/apm-aws-lambda: ci: add info traces to help with debugging (elastic#114) ci: notify when a release tag has been created and published (elastic#113) Update .ci/Jenkinsfile Update .ci/Jenkinsfile Update apm-lambda-extension/cli/build-and-publish.js
|
68bc2b6 should do that trick, adding the suffix Therefore, if running locally then the extension layer is |
| --output json \ | ||
| publish-layer-version \ | ||
| --layer-name "${ELASTIC_LAYER_NAME}" \ | ||
| --layer-name "$(ELASTIC_LAYER_NAME)-$(ARCHITECTURE)" \ |
There was a problem hiding this comment.
The make goal publish is the one in charge to apply the layer-name with the architecture since the Makefile is in charge to transform the GOARCH in the expected format.
5 participants
What
Add elastic prefix in the layer name, version as suffix. Additionally, it adds the arch as suffix too.
Implementation details
CI is setting the env variable
ELASTIC_LAYER_NAMEdynamically if a new tag release is created.Issue
Closes #110
Test