Skip to content

Conversation

v1v
Copy link
Member

@v1v v1v commented Feb 2, 2022

What

Add debug traces.
Store files generated while publishing the ARN lambda (the output from aws lambda --output json publish-layer-version)
Fix a parsing error in the CI that I was not able to reproduce it locally

12:29:09  make create-arn-file
12:29:09  make[1]: Entering directory '/var/lib/jenkins/workspace/ibrary_apm-aws-lambda-mbp_v0.0.3/src/github.com/elastic/apm-aws-lambda/apm-lambda-extension'
12:29:09  parse error: Invalid numeric literal at line 1, column 5

image

Test

AWS_ACCESS_KEY_ID=*** \
AWS_SECRET_ACCESS_KEY=*** \
BRANCH_NAME=v0.0.0.1 \
SUFFIX_ARN_FILE=arn.md \
ELASTIC_LAYER_NAME=v1v-aws-lambda-test \
make publish-in-all-aws-regions
publish 'v1v-aws-lambda-test' in af-south-1
publish 'v1v-aws-lambda-test' in eu-north-1
publish 'v1v-aws-lambda-test' in ap-south-1
publish 'v1v-aws-lambda-test' in eu-west-3
publish 'v1v-aws-lambda-test' in eu-west-2
publish 'v1v-aws-lambda-test' in eu-south-1
publish 'v1v-aws-lambda-test' in eu-west-1
publish 'v1v-aws-lambda-test' in ap-northeast-3
publish 'v1v-aws-lambda-test' in ap-northeast-2
publish 'v1v-aws-lambda-test' in me-south-1
publish 'v1v-aws-lambda-test' in ap-northeast-1
publish 'v1v-aws-lambda-test' in sa-east-1
publish 'v1v-aws-lambda-test' in ca-central-1
publish 'v1v-aws-lambda-test' in ap-east-1
publish 'v1v-aws-lambda-test' in ap-southeast-1
publish 'v1v-aws-lambda-test' in ap-southeast-2
publish 'v1v-aws-lambda-test' in eu-central-1
publish 'v1v-aws-lambda-test' in ap-southeast-3
publish 'v1v-aws-lambda-test' in us-east-1
publish 'v1v-aws-lambda-test' in us-east-2

then

SUFFIX_ARN_FILE=arn.md make create-arn-file                          
INFO: create-arn-table ARN(arn:aws:lambda:af-south-1:267093732750:layer:v1v-aws-lambda-test:1):region(af-south-1):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:ap-east-1:267093732750:layer:v1v-aws-lambda-test:1):region(ap-east-1):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:ap-northeast-1:267093732750:layer:v1v-aws-lambda-test:1):region(ap-northeast-1):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:ap-northeast-2:267093732750:layer:v1v-aws-lambda-test:1):region(ap-northeast-2):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:ap-northeast-3:267093732750:layer:v1v-aws-lambda-test:1):region(ap-northeast-3):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:ap-south-1:267093732750:layer:v1v-aws-lambda-test:1):region(ap-south-1):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:ap-southeast-1:267093732750:layer:v1v-aws-lambda-test:1):region(ap-southeast-1):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:ap-southeast-2:267093732750:layer:v1v-aws-lambda-test:1):region(ap-southeast-2):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:ap-southeast-3:267093732750:layer:v1v-aws-lambda-test:1):region(ap-southeast-3):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:ca-central-1:267093732750:layer:v1v-aws-lambda-test:1):region(ca-central-1):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:eu-central-1:267093732750:layer:v1v-aws-lambda-test:1):region(eu-central-1):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:eu-north-1:267093732750:layer:v1v-aws-lambda-test:1):region(eu-north-1):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:eu-south-1:267093732750:layer:v1v-aws-lambda-test:1):region(eu-south-1):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:eu-west-1:267093732750:layer:v1v-aws-lambda-test:1):region(eu-west-1):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:eu-west-2:267093732750:layer:v1v-aws-lambda-test:1):region(eu-west-2):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:eu-west-3:267093732750:layer:v1v-aws-lambda-test:1):region(eu-west-3):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:me-south-1:267093732750:layer:v1v-aws-lambda-test:1):region(me-south-1):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:sa-east-1:267093732750:layer:v1v-aws-lambda-test:1):region(sa-east-1):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:us-east-1:267093732750:layer:v1v-aws-lambda-test:1):region(us-east-1):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:us-east-2:267093732750:layer:v1v-aws-lambda-test:1):region(us-east-2):arch(x86_64)
INFO: create-arn-table ARN(arn:aws:lambda:us-west-1:267093732750:layer:v1v-aws-lambda-test:1):region(us-west-1):arch(x86_64)

image

Important

As far as I see the output from publish-lambda does not contain any sensitive details unless the content.location is something to be careful about:

{
    "Content": {
        "Location": "https://prod-cpt-c0-h5e2y-layers.s3.af-south-1.amazonaws.com/snapshots/267093732750/v1v-aws-lambda-test-REDACTED?versionId=REDACTED&X-Amz-Security-Token=REDACTED&X-Amz-Algorithm=REDACTED&X-Amz-Date=20220202T132137Z&X-Amz-SignedHeaders=host&X-Amz-Expires=600&X-Amz-Credential=REDACTED%2F20220202%2Faf-south-1%2Fs3%2Faws4_request&X-Amz-Signature=REDACTED",
        "CodeSha256": "REDACTED",
        "CodeSize": 3839771
    },
    "LayerArn": "arn:aws:lambda:af-south-1:267093732750:layer:v1v-aws-lambda-test",
    "LayerVersionArn": "arn:aws:lambda:af-south-1:267093732750:layer:v1v-aws-lambda-test:1",
    "Description": "AWS Lambda Extension Layer for Elastic APM x86_64",
    "CreatedDate": "2022-02-02T13:21:40.835+0000",
    "Version": 1,
    "LicenseInfo": "Apache-2.0"
}

@v1v v1v requested review from a team and estolfo February 2, 2022 13:38
@v1v v1v self-assigned this Feb 2, 2022
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Feb 2, 2022
always {
archiveArtifacts(allowEmptyArchive: true, artifacts: "${BASE_DIR}/apm-lambda-extension/.regions")
archiveArtifacts(allowEmptyArchive: true, artifacts: "${BASE_DIR}/apm-lambda-extension/*${SUFFIX_ARN_FILE}")
archiveArtifacts(allowEmptyArchive: true, artifacts: "${BASE_DIR}/apm-lambda-extension/.aws")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This folder contains the output from the aws command publish-layer-version

As far as I see https://docs.aws.amazon.com/cli/latest/reference/lambda/publish-layer-version.html#output does not mention about any sensitive data in the output

image

Storing those files will help to debug what's going on if something bad happened while publishing a new release.

@ghost
Copy link

ghost commented Feb 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-02-02T13:38:20.266+0000

  • Duration: 9 min 13 sec

  • Commit: cd4746a

Test stats 🧪

Test Results
Failed 0
Passed 84
Skipped 0
Total 84

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v v1v added the Team:Automation Label for the Observability productivity team label Feb 2, 2022
@v1v v1v merged commit ae665af into elastic:main Feb 2, 2022
v1v added a commit to v1v/apm-aws-lambda that referenced this pull request Feb 3, 2022
…ambda into feature/publishing-changes

* 'feature/publishing-changes' of github.com:v1v/apm-aws-lambda:
  ci: add info traces to help with debugging (elastic#114)
  ci: notify when a release tag has been created and published (elastic#113)
  Update .ci/Jenkinsfile
  Update .ci/Jenkinsfile
  Update apm-lambda-extension/cli/build-and-publish.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension Team:Automation Label for the Observability productivity team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants