Skip to content

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Aug 30, 2022

What does this pull request do?

The final merged spec removed the request ID for ELB triggers, and narrowed the service.origin.name. With this PR our implementation matches the current spec

Related issues

Closes #1622
Ref #1605 and #1609

@basepi basepi requested a review from trentm August 30, 2022 17:58
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link

ghost commented Aug 30, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-30T17:58:55.537+0000

  • Duration: 30 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 4974
Skipped 3338
Total 8312

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ghost
Copy link

ghost commented Aug 30, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (66/66) 💚
Files 100.0% (225/225) 💚
Classes 100.0% (225/225) 💚
Lines 89.841% (17439/19411) 👍
Conditionals 77.279% (3187/4124) 👍 0.024

@basepi basepi merged commit 070e0c7 into elastic:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[META 679] Add support for ELB and Lambda URL metadata in lambda integrations
2 participants