Skip to content

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Aug 8, 2022

Elastic Load Balancer (ELB) can now be attached to lambda functions directly, without an API Gateway. This necessitates an additional section for event parsing.

There is no obvious candidate for trigger.request_id, so I've omitted it for this trigger type.

I've also removed the context.service.origin.version as compared to API gateway, since it's not relevant for ELB.

Python implementation here

  • Create PR as draft
  • Approval by at least one other agent
  • Mark as Ready for Review (automatically requests reviews from all agents and PM via CODEOWNERS)
    • Remove PM from reviewers if impact on product is negligible
    • Remove agents from reviewers if the change is not relevant for them
  • Approved by at least 2 agents + PM (if relevant)
  • Merge after 7 days passed without objections
  • Create implementation issues through the meta issue template (this will automate issue creation for individual agents)

/schedule 2022-08-30

@basepi basepi requested review from trentm and AlexanderWert August 8, 2022 18:46
@ghost
Copy link

ghost commented Aug 8, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-29T05:27:00.604+0000

  • Duration: 5 min 49 sec

@basepi basepi marked this pull request as ready for review August 10, 2022 22:32
@basepi basepi requested review from a team as code owners August 10, 2022 22:32
@basepi basepi removed request for a team August 10, 2022 22:36
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly add context.cloud.origin.service.name = 'lambda url' if the event.requestContext.domainNamematches.lambda-url..on.aws`.

@basepi basepi requested a review from AlexanderWert August 22, 2022 18:37
@basepi
Copy link
Contributor Author

basepi commented Aug 23, 2022

Scheduled to be merged on 2022-08-30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants