Make LaunchManager's IResourceDeltaVisitors more light weight #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
lightweight-resource-delta-processing-in-LaunchManager
branch
from
2ea5a99 to
737994f
Compare
1. Implement the IResourceDeltaVisitor in LaunchManager as lambda's instead of nested classes. 2. Defer obtaining a delta's resource as long as possible and instead only on the full-path of the delta. Previously the resource of each delta was obtained without real need, which lead to potentially unnecessary object creation.
HannesWell
force-pushed
the
lightweight-resource-delta-processing-in-LaunchManager
branch
from
737994f to
e4944f4
Compare
HannesWell
deleted the
lightweight-resource-delta-processing-in-LaunchManager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the resource of each delta was obtained without real need, which lead to potentially unnecessary object creation.