Clean Code for bundles/org.eclipse.e4.ui.workbench.addons.swt

[eclipse-platform-bot]

The following cleanups were applied:

• Add final modifier to private fields
• Add missing '@Deprecated' annotations
• Add missing '@Override' annotations
• Add missing '@Override' annotations to implementations of interface methods
• Convert control statement bodies to block
• Make inner classes static where possible
• Remove trailing white spaces on all lines
• Remove unnecessary array creation for varargs
• Remove unnecessary suppress warning tokens
• Remove unused imports
• Remove unused private constructors
• Remove unused private fields
• Remove unused private methods
• Remove unused private types
• Replace deprecated calls with inlined content where possible
• Use pattern matching for instanceof

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.workbench.addons.swt/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 06d3bd472cd5870ac0768d8182d751f5529f28a3 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Fri, 3 Oct 2025 03:11:35 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/bundles/org.eclipse.e4.ui.workbench.addons.swt/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.workbench.addons.swt/META-INF/MANIFEST.MF
index 7cda4cc33f..72b95a276a 100644
--- a/bundles/org.eclipse.e4.ui.workbench.addons.swt/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.workbench.addons.swt/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.workbench.addons.swt;singleton:=true
-Bundle-Version: 1.5.800.qualifier
+Bundle-Version: 1.5.900.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

 3 000 files  +3   3 000 suites  +3   2h 40m 46s ⏱️ - 1h 38m 40s
 8 215 tests ±0   7 966 ✅ +1  249 💤 ±0  0 ❌  - 1 
23 565 runs  ±0  22 771 ✅ +1  794 💤 ±0  0 ❌  - 1 

Results for commit 14d4800. ± Comparison against base commit 895ca2e.

This pull request removes 283 and adds 283 tests. Note that renamed tests count towards both.

org.eclipse.jface.text.tests.DefaultPairMatcherTest ‑ testBoundaries
org.eclipse.jface.text.tests.DefaultPairMatcherTest ‑ testBug156426
org.eclipse.jface.text.tests.DefaultPairMatcherTest ‑ testBug377417
org.eclipse.jface.text.tests.DefaultPairMatcherTest ‑ testCloseMatches
org.eclipse.jface.text.tests.DefaultPairMatcherTest ‑ testCloseMatches1
org.eclipse.jface.text.tests.DefaultPairMatcherTest ‑ testIncompleteMatch
org.eclipse.jface.text.tests.DefaultPairMatcherTest ‑ testIncompleteMatch1
org.eclipse.jface.text.tests.DefaultPairMatcherTest ‑ testNesting
org.eclipse.jface.text.tests.DefaultPairMatcherTest ‑ testPartitioned
org.eclipse.jface.text.tests.DefaultPairMatcherTest ‑ testSimpleMatchDifferentMatchers
…

JFaceTextTestSuite AbstractReconcilerTest ‑ testCancellingWhenClean
JFaceTextTestSuite AbstractReconcilerTest ‑ testCancellingWhenRunning
JFaceTextTestSuite AbstractReconcilerTest ‑ testDirtyingWhenClean
JFaceTextTestSuite AbstractReconcilerTest ‑ testDirtyingWhenRunning
JFaceTextTestSuite AbstractReconcilerTest ‑ testInitialReconcile
JFaceTextTestSuite AbstractReconcilerTest ‑ testReplacingDocumentWhenClean
JFaceTextTestSuite AbstractReconcilerTest ‑ testReplacingDocumentWhenRunning
JFaceTextTestSuite AnnotationOnTabTest ‑ testTextBoundsMatchPaintedArea
JFaceTextTestSuite AnnotationRulerColumnTest ‑ testDrawWithEmptyProjection
JFaceTextTestSuite AsyncContentAssistTest ‑ testAsyncFailureStackOverflow
…

This pull request removes 2 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.

org.eclipse.jface.text.tests.MultiSelectionTest ‑ testViewer
org.eclipse.jface.text.tests.contentassist.FilteringAsyncContentAssistTests ‑ testFastCompletionsNotFilteredUntilLongComplitionsCalculated

JFaceTextTestSuite FilteringAsyncContentAssistTests ‑ testFastCompletionsNotFilteredUntilLongComplitionsCalculated
JFaceTextTestSuite MultiSelectionTest ‑ testViewer

♻️ This comment has been updated with latest results.

[akurtakov]

New warnings are due to eclipse-platform/eclipse.platform.swt#2563

[akurtakov]

Merging as new warnings are unrelated.