Deprecation: Cursor(Device, ImageData, ImageData, int, int) #2563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedejeanne
reviewed
Oct 1, 2025
There was a problem hiding this comment.
@ShahzaibIbrahim is it possible to replace the remaining usages of the deprecated methods? There are 5 new warnings (see failing checks)
|
@fedejeanne those warnings are all from the test. What I can do now is to suppress the warning for deprecation on those test. |
The constructor Cursor(Device, ImageData source, ImageData mask, int hotspotX, int hotspotY) allows creating a cursor by providing a source image and a 1-bit mask to define transparency. This approach requires developers to manually define mask pixels and works reliably only in fixed DPI environments.recommended to use: Cursor(Device device, ImageDataProvider imageDataProvider, int hotspotX, int hotspotY).
ShahzaibIbrahim
force-pushed
the
master-462
branch
from
2b9121b to
67bbb41
Compare
fedejeanne
approved these changes
Oct 2, 2025
|
It is a good practice before deprecating some method to go through Eclipse TLP codebase and switch to new way. Otherwise we end up with pile of deprecation warnings that make working on the codebase a nightmare. E.g. https://github.com/eclipse-platform/eclipse.platform.ui/pull/3278/checks?check_run_id=51871277212 . Can I count on you doing this work? |
akurtakov
added a commit
to akurtakov/eclipse.platform.ui
that referenced
this pull request
Oct 3, 2025
Stop pointing to deprecated Cursor constructors in eclipse-platform/eclipse.platform.swt#2563
akurtakov
added a commit
to eclipse-platform/eclipse.platform.ui
that referenced
this pull request
Oct 3, 2025
Stop pointing to deprecated Cursor constructors in eclipse-platform/eclipse.platform.swt#2563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor Cursor(Device, ImageData source, ImageData mask, int hotspotX, int hotspotY) allows creating a cursor by providing a source image and a 1-bit mask to define transparency. This approach requires developers to manually define mask pixels and works reliably only in fixed DPI environments.
With the introduction of multi-monitor DPI support, this constructor produces inconsistent results.