Skip to content

Spin the event loop to process the paste operation completely. #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2025
Merged

Spin the event loop to process the paste operation completely. #2489

merged 1 commit into from
Sep 9, 2025

Conversation

raghucssit
Copy link
Contributor

Manually when copy and paste done on combo it works as expected. But while calling copy and paste API on combo there is an inconsistency. It is due to pending UI events before we check text on combo.

see #2485

@raghucssit raghucssit force-pushed the fix_combo_copy_paste_test branch from 492302a to a0ea5cf Compare September 8, 2025 14:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025 •
edited
Loading

Test Results

   409 files   -   137     409 suites   - 137   19m 16s ⏱️ - 10m 17s
 4 394 tests  -    37   4 379 ✅  -    35   15 💤  -  2  0 ❌ ±0 
12 635 runs   - 4 129  12 525 ✅  - 4 112  110 💤  - 17  0 ❌ ±0 

Results for commit 151a7ca. ± Comparison against base commit fdbb769.

This pull request removes 37 tests. 
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_dollarSign
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_emptyString
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letterA
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16LE_null
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_AsciiLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_Asciiletter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_LotsOfLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letters
…

♻️ This comment has been updated with latest results.

@raghucssit raghucssit force-pushed the fix_combo_copy_paste_test branch from a0ea5cf to b46f409 Compare September 8, 2025 15:08
@laeubi laeubi added the gtk4 GTK4 issues label Sep 8, 2025
@laeubi
Copy link
Contributor

laeubi commented Sep 8, 2025

@raghucssit should we enhance javadoc to mention that calling copy / paste will not immediate update the state and one should possibly use asyncExec wif accessing the control is desired (that would probably also work for the test to use async exec but it of course complicates the test assertions maybe).

@raghucssit raghucssit force-pushed the fix_combo_copy_paste_test branch from b46f409 to bdeb6a3 Compare September 9, 2025 07:44
@raghucssit
Copy link
Contributor Author

@raghucssit should we enhance javadoc to mention that calling copy / paste will not immediate update the state and one should possibly use asyncExec wif accessing the control is desired (that would probably also work for the test to use async exec but it of course complicates the test assertions maybe).

I have updated copy/paste doc.

laeubi
laeubi reviewed Sep 9, 2025
View reviewed changes
Copy link
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not recommend spinning the event loop except in text, in regular UI code using asyncExec should be sufficient.

@raghucssit
Spin the event loop to process the paste operation completely.
151a7ca 
Manually when copy and paste done on combo it works as expected. But
while calling copy and paste API on combo there is an inconsistency. It
is due to pending UI events before we check text on combo.

see eclipse-platform#2485
@raghucssit raghucssit force-pushed the fix_combo_copy_paste_test branch from bdeb6a3 to 151a7ca Compare September 9, 2025 09:22
@iloveeclipse
Copy link
Member

Known GTK4 tests are failing, the fixed Combo tests are passing.

@iloveeclipse iloveeclipse merged commit f858239 into eclipse-platform:master Sep 9, 2025
16 of 17 checks passed
@iloveeclipse iloveeclipse mentioned this pull request Sep 9, 2025
Closed
@iloveeclipse iloveeclipse linked an issue Sep 9, 2025 that may be closed by this pull request
GTK4: Combo copy and paste test failure #2485
Closed
This was referenced Sep 9, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iloveeclipse iloveeclipse iloveeclipse approved these changes

@laeubi laeubi Awaiting requested review from laeubi

Assignees
No one assigned
Labels
gtk4 GTK4 issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GTK4: Combo copy and paste test failure
3 participants
@raghucssit @laeubi @iloveeclipse