GTK4: Combo copy and paste test failure

[raghucssit]

I have taken this failure from #2124

Both copy and paste tests fail on RHEL-10 with GTK4.

paste:

org.junit.ComparisonFailure: expected:<1[23]456> but was:<1[]456>
	at org.junit.Assert.assertEquals(Assert.java:117)
	at org.junit.Assert.assertEquals(Assert.java:146)
	at org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Combo.test_paste(Test_org_eclipse_swt_widgets_Combo.java:504)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	Suppressed: java.lang.Throwable: Screenshot written to /tmp/org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Combo.test_paste.png
		at org.eclipse.test.Screenshots$ScreenshotOnFailure.failed(Screenshots.java:41)

copy:

org.junit.ComparisonFailure: expected:<[23]123456> but was:<[]123456>
	at org.junit.Assert.assertEquals(Assert.java:117)
	at org.junit.Assert.assertEquals(Assert.java:146)
	at org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Combo.test_copy(Test_org_eclipse_swt_widgets_Combo.java:239)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	Suppressed: java.lang.Throwable: Screenshot written to /tmp/org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Combo.test_copy.png
		at org.eclipse.test.Screenshots$ScreenshotOnFailure.failed(Screenshots.java:41)

[raghucssit]

I will investigate this issue..

[akurtakov]

There is #2444 for this one but it needs improvements.

[raghucssit]

Manually this cannot be reproduced As I have tried the steps as per test case.

@Test
public void test_copy() {
	if (SwtTestUtil.isCocoa) {
		// TODO Fix Cocoa failure.
		if (SwtTestUtil.verbose) {
			System.out
					.println("Excluded test_copy(org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Combo).");
		}
		return;
	}
	combo.setText("123456");
	combo.setSelection(new Point(1,3));
	combo.copy();
	combo.setSelection(new Point(0,0));
	combo.paste();
	assertEquals("23123456", combo.getText());
}

Here is the result.

combo-copy-paste.webm

I hope I am not missing any step in manual attempt.

[raghucssit]

Also another observation is Combo#copy works fine.. As I have verified clipboard content after copy it holds the correct content.
Here is manual snippet.

public class ComboCopyPasteManual {
	public static void main(String[] args) {
		Display display = new Display();
		Shell shell = new Shell(display);
		shell.setLayout(new GridLayout());
		shell.setText("Combo Copy/Paste Manual Test");

		Combo combo = new Combo(shell, SWT.DROP_DOWN);
		combo.setSize(200, 30);

		combo.setText("123456");

		combo.setSelection(new Point(1, 3));
		System.out.println("Initial text = " + combo.getText());
		System.out.println("Selected substring = " + combo.getText().substring(1, 3));

		combo.copy();
		System.out.println("Copied text to clipboard");

		Clipboard clipboard = new Clipboard(combo.getDisplay());
		String clipText = (String) clipboard.getContents(TextTransfer.getInstance());
		System.out.println("Clipboard content after combo.copy() = " + clipText);
		clipboard.dispose();

		combo.setSelection(new Point(0, 0));
		combo.paste();

		System.out.println("After paste text = " + combo.getText());
		System.out.println("Expected result  = 23123456");

		shell.setSize(400, 200);
		shell.open();
		while (!shell.isDisposed()) {
			if (!display.readAndDispatch())
				display.sleep();
		}
		display.dispose();
	}

[raghucssit]

@akurtakov User can never get into copy paste issue manually as I have tried above.. Can I disable this test ?

[akurtakov]

@akurtakov User can never get into copy paste issue manually as I have tried above.. Can I disable this test ?

I would rather see the test be changed to spin the event loop instead of disable.

[raghucssit]

@akurtakov User can never get into copy paste issue manually as I have tried above.. Can I disable this test ?

I would rather see the test be changed to spin the event loop instead of disable.

Yeah.. I did it.. Locally tests passed.
On build machine is gtk4 enabled for tests ?

[laeubi]

On build machine is gtk4 enabled for tests ?

GTK4 is only enabled for PRs that add the GTK4 label.

[raghucssit]

GTK4

I don't have rights to add label. Please add GTK4 label for my PR.

[iloveeclipse]

I don't have rights to add label. Please add GTK4 label for my PR.

Done