Skip to content

Seperate ThreadPoolExecutor for heartbeat #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Seperate ThreadPoolExecutor for heartbeat #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
537afd9
Seperate ThreadPoolExecutor for heartbeat
afurche Dec 27, 2024
8bdbaad
make it a patch change, no end user changes
dlopes7 Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dynatrace_extension/__about__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
# SPDX-License-Identifier: MIT


__version__ = "1.3.0"
__version__ = "1.3.1"
4 changes: 3 additions & 1 deletion dynatrace_extension/sdk/extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@

CALLBACKS_THREAD_POOL_SIZE = 100
INTERNAL_THREAD_POOL_SIZE = 20
HEARTBEAT_THREAD_POOL_SIZE = 10

RFC_3339_FORMAT = "%Y-%m-%dT%H:%M:%SZ"
DATASOURCE_TYPE = "python"
Expand Down Expand Up @@ -220,6 +221,7 @@ def __init__(self, name: str = "") -> None:
# Executors for the callbacks and internal methods
self._callbacks_executor = ThreadPoolExecutor(max_workers=CALLBACKS_THREAD_POOL_SIZE)
self._internal_executor = ThreadPoolExecutor(max_workers=INTERNAL_THREAD_POOL_SIZE)
self._heartbeat_executor = ThreadPoolExecutor(max_workers=HEARTBEAT_THREAD_POOL_SIZE)

# Extension metrics
self._metrics_lock = RLock()
Expand Down Expand Up @@ -827,7 +829,7 @@ def _timediff_iteration(self):
self._scheduler.enterabs(next_timestamp, 1, self._timediff_iteration)

def _heartbeat_iteration(self):
self._internal_executor.submit(self._heartbeat)
self._heartbeat_executor.submit(self._heartbeat)
next_timestamp = self._get_and_set_next_internal_callback_timestamp("heartbeat", HEARTBEAT_INTERVAL)
self._scheduler.enterabs(next_timestamp, 2, self._heartbeat_iteration)

Expand Down
Loading