Seperate ThreadPoolExecutor for heartbeat #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a single ThreadPoolExecutor takes care of callbacks sending metrics, logs, checking time diff and sending hearbeat.
Knowning that log parsing takes some time on EEC side, when there are many log requests in as single interval (when using
report_log_event()1 request is created for each single log, due to that it's possible for tens or hundreds of requests in each interval), the heartbeat might not be send on time and EEC could restart the process.This PR adds a seperate ThreadPoolExecutor for solely heartbeat purpose, making it independent from other functionalities.